Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,sessionctx: Add correctness for more system variables (#7196) #9420

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #7196

What is changed and how it works?

Check List

Tests

  • Unit test

@crazycs520 crazycs520 added type/2.0 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Feb 22, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Feb 22, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2019
@zz-jason zz-jason merged commit c71588e into pingcap:release-2.0 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants