executor,sessionctx: Add correctness for more system variables #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Jul 31, 2018
jackysp
reviewed
Jul 31, 2018
|
@zz-jason PTAL |
|
/run-all-tests |
zz-jason
added
type/enhancement
zz-jason
reviewed
Aug 9, 2018
|
@spongedu seems we should specially handle the string "default". |
|
/run-common-test |
|
@zz-jason We've dealed with value |
zz-jason
reviewed
Aug 10, 2018
|
/run-all-tests |
|
@jackysp PTAL |
|
/run-all-tests |
zhexuany
reviewed
Aug 15, 2018
zhexuany
reviewed
Aug 15, 2018
Signed-off-by: spongedc <duchuangucas@live.com>
zz-jason
approved these changes
Aug 17, 2018
|
/run-all-tests |
zz-jason
added
status/LGT2
|
/run-integration-ddl-test |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Feb 22, 2019
zz-jason
pushed a commit
that referenced
this pull request
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
What is the type of the changes? (mandatory)
for #7195
How has this PR been tested? (mandatory)
Unittest
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
Does this PR need to be added to the release notes? (mandatory)
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)