mounter(ticdc): ignore checksum v2 #11523
Conversation
ti-chi-bot
bot
added
release-note-none
cdc/entry/mounter.go
Outdated
| @@ -434,6 +434,13 @@ func (m *mounter) verifyChecksum( | |||
| decoder = m.decoder | |||
| } | |||
|
|
|||
| version := decoder.ChecksumVersion() | |||
| if version != 0 { | |||
| log.Info("checksum is not v1, this happens since upstream TiDB is in a higher version, ignore it", | |||
There was a problem hiding this comment.
Would this log flooding?
There was a problem hiding this comment.
this only happens in the upgrade scenario, it should not take too long, so not too match logs.
There was a problem hiding this comment.
Rolling upgrade would take more than 10 minutes if there are a lot of tables.
There was a problem hiding this comment.
ti-chi-bot
bot
added
needs-1-more-lgtm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #11523 +/- ##
================================================
Coverage ? 57.4669%
================================================
Files ? 854
Lines ? 126083
Branches ? 0
================================================
Hits ? 72456
Misses ? 48221
Partials ? 5406 |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
cherry-pick-approved
|
/retest |
What problem does this PR solve?
Issue Number: close #11524
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note