Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): ignore checksum v2 #11523

Merged
merged 3 commits into from
Sep 11, 2024
Merged

mounter(ticdc): ignore checksum v2 #11523

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3f2f92
ignore checksum v2
3AceShowHand Aug 27, 2024
ecb9284
ignore checksum v2
3AceShowHand Aug 27, 2024
3f352a8
ignore checksum v2
3AceShowHand Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cdc/entry/mounter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,13 @@
decoder = m.decoder
}

version := decoder.ChecksumVersion()
if version != 0 {
log.Info("checksum is not v1, this happens since upstream TiDB is in a higher version, ignore it",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this log flooding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only happens in the upgrade scenario, it should not take too long, so not too match logs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolling upgrade would take more than 10 minutes if there are a lot of tables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use https://github.com/pingcap/tidb/blob/4f85a3599a03da596e098e79f55d37fd9be5f6b4/pkg/util/logutil/log.go#L400-L406

zap.Int("version", version))
return 0, true, nil
}

Check warning on line 442 in cdc/entry/mounter.go

View check run for this annotation

Codecov / codecov/patch

cdc/entry/mounter.go#L439-L442 

Added lines #L439 - L442 were not covered by tests

// if the checksum cannot be found, which means the upstream TiDB checksum is not enabled,
// so return matched as true to skip check the event.
first, ok := decoder.GetChecksum()
Expand Down
Loading