refactor(rust): remove redundant if branch in nested parquet

[nameexhaustion]

small cleanup after #11803 - the if branch is never executed, so remove it to avoid confusing the next person that reads this.

[ritchie46]

@nameexhaustion our polars-arrow tests don't run yet in CI. Can you run those tests and verify that they work? (save a few failing ones due to the new nullable info).

[nameexhaustion]

@ritchie46 , appear to be OK (assuming I was meant to run cargo test from the polars-arrow directory

ubuntu@localhost:~/git/polars/crates/polars-arrow$ cargo test
warning: /home/ubuntu/git/polars/crates/polars-error/Cargo.toml: `default-features` is ignored for parquet2, since `default-features` was not specified for `workspace.dependencies.parquet2`, this could become a hard error in the future
    Updating git repository `https://github.com/orlp/aHash`
    Updating crates.io index
   Compiling cfg-if v1.0.0
   Compiling proc-macro2 v1.0.66
   Compiling unicode-ident v1.0.11
   Compiling libc v0.2.147
   Compiling autocfg v1.1.0
   Compiling syn v1.0.109
   Compiling libm v0.2.7
   Compiling version_check v0.9.4
   Compiling memchr v2.6.3
   Compiling regex-syntax v0.7.4
   Compiling ppv-lite86 v0.2.17
   Compiling num-traits v0.2.16
   Compiling crossbeam-utils v0.8.16
   Compiling aho-corasick v1.0.3
   Compiling memoffset v0.9.0
   Compiling quote v1.0.32
   Compiling getrandom v0.2.10
   Compiling syn v2.0.28
   Compiling rand_core v0.6.4
   Compiling crossbeam-epoch v0.9.15
   Compiling serde v1.0.188
   Compiling regex-automata v0.3.6
   Compiling log v0.4.20
   Compiling either v1.9.0
   Compiling rand_chacha v0.3.1
   Compiling scopeguard v1.2.0
   Compiling semver v1.0.18
   Compiling rand v0.8.5
   Compiling ahash v0.8.3 (https://github.com/orlp/aHash?branch=fix-arm-intrinsics#80685f88)
   Compiling rayon-core v1.12.0
   Compiling once_cell v1.18.0
   Compiling getrandom v0.1.16
   Compiling crossbeam-deque v0.8.3
   Compiling crc32fast v1.3.2
   Compiling typenum v1.17.0
   Compiling regex-syntax v0.6.29
   Compiling thiserror v1.0.44
   Compiling serde_json v1.0.104
   Compiling regex v1.9.3
   Compiling env_logger v0.8.4
   Compiling rustc_version v0.4.0
   Compiling num-integer v0.1.45
   Compiling generic-array v0.14.7
   Compiling build_const v0.2.2
   Compiling simdutf8 v0.1.4
   Compiling unicode-xid v0.2.4
   Compiling ryu v1.0.15
   Compiling rustix v0.38.8
   Compiling itoa v1.0.9
   Compiling byteorder v1.4.3
   Compiling synstructure v0.12.6
   Compiling rand_regex v0.15.1
   Compiling serde_derive v1.0.188
   Compiling thiserror-impl v1.0.44
   Compiling bytemuck_derive v1.4.1
   Compiling crc v1.8.1
   Compiling rayon v1.8.0
   Compiling arrow2 v0.17.4
   Compiling bytemuck v1.13.1
   Compiling rand_core v0.5.1
   Compiling quickcheck v1.0.3
   Compiling casey v0.4.0
   Compiling chrono v0.4.31
   Compiling num-bigint v0.2.6
   Compiling clap_lex v0.5.1
   Compiling rle-decode-fast v1.0.3
   Compiling linux-raw-sys v0.4.5
   Compiling ciborium-io v0.2.1
   Compiling unicode-segmentation v1.10.1
   Compiling plotters-backend v0.3.5
   Compiling ethnum v1.3.2
   Compiling bitflags v2.4.0
   Compiling lazy_static v1.4.0
   Compiling dyn-clone v1.0.12
   Compiling futures-core v0.3.28
   Compiling half v1.8.2
   Compiling anstyle v1.0.4
   Compiling foreign_vec v0.1.0
   Compiling ciborium-ll v0.2.1
   Compiling clap_builder v4.4.6
   Compiling heck v0.3.3
   Compiling plotters-svg v0.3.5
   Compiling sample-std v0.1.1
   Compiling libflate_lz77 v1.2.0
   Compiling rand_chacha v0.2.2
   Compiling zerocopy-derive v0.2.0
   Compiling tokio-macros v2.1.0
   Compiling itertools v0.10.5
   Compiling bytes v1.4.0
   Compiling pin-project-lite v0.2.12
   Compiling adler32 v1.2.0
   Compiling adler v1.0.2
   Compiling cast v0.3.0
   Compiling allocator-api2 v0.2.16
   Compiling hash_hasher v2.0.3
   Compiling doc-comment v0.3.3
   Compiling same-file v1.0.6
   Compiling hashbrown v0.14.0
   Compiling walkdir v2.3.3
   Compiling tokio v1.31.0
   Compiling zerocopy v0.3.0
   Compiling clap v4.4.6
   Compiling miniz_oxide v0.7.1
   Compiling criterion-plot v0.5.0
   Compiling libflate v1.4.0
   Compiling sample-test-macros v0.1.1
   Compiling digest v0.9.0
   Compiling is-terminal v0.4.9
   Compiling rand v0.7.3
   Compiling strum_macros v0.18.0
   Compiling plotters v0.3.5
   Compiling snap v0.2.5
   Compiling uuid v0.8.2
   Compiling ciborium v0.2.1
   Compiling polars-error v0.33.2 (/home/ubuntu/git/polars/crates/polars-error)
   Compiling typed-builder v0.5.1
   Compiling rand_xorshift v0.3.0
   Compiling bitflags v1.3.2
   Compiling tinytemplate v1.2.1
   Compiling strum v0.18.0
   Compiling streaming-iterator v0.1.9
   Compiling anes v0.1.6
   Compiling futures-io v0.3.28
   Compiling futures-sink v0.3.28
   Compiling unarray v0.1.4
   Compiling oorandom v11.1.3
   Compiling proptest v1.2.0
   Compiling tokio-util v0.7.8
   Compiling criterion v0.5.1
   Compiling sample-arrow2 v0.17.1
   Compiling sample-test v0.1.1
   Compiling flate2 v1.0.26
   Compiling crossbeam-channel v0.5.8
   Compiling polars-arrow v0.33.2 (/home/ubuntu/git/polars/crates/polars-arrow)
   Compiling avro-rs v0.13.0
    Finished test [unoptimized + debuginfo] target(s) in 1m 03s
warning: the following packages contain code that will be rejected by a future version of Rust: snap v0.2.5
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
     Running unittests src/lib.rs (/home/ubuntu/git/polars/target/debug/deps/polars_arrow-dd4c87d8ec928bcb)

running 33 tests
test bitmap::utils::chunk_iterator::merge::tests::test_merge_reversed ... ok
test legacy::compute::take::test::test_utf8_kernel ... ok
test bitmap::utils::chunk_iterator::merge::tests::test_merge_reversed_offset2 ... ok
test legacy::kernels::ewm::variance::test::test_ewm_cov ... ok
test ffi::schema::tests::test_all ... ok
test legacy::kernels::ewm::average::test::test_ewm_mean_with_null ... ok
test legacy::kernels::ewm::average::test::test_ewm_mean_without_null ... ok
test legacy::kernels::ewm::variance::test::test_ewm_min_periods ... ok
test legacy::kernels::list::test::test_sublist_get ... ok
test legacy::kernels::ewm::variance::test::test_ewm_std ... ok
test legacy::kernels::list::test::test_sublist_get_indexes ... ok
test legacy::kernels::rolling::no_nulls::min_max::test::test_rolling_min_max ... ok
test legacy::kernels::rolling::no_nulls::quantile::test::test_rolling_median ... ok
test legacy::kernels::ewm::variance::test::test_ewm_var ... ok
test legacy::kernels::rolling::no_nulls::sum::test::test_rolling_sum ... ok
test legacy::kernels::rolling::no_nulls::quantile::test::test_rolling_quantile_limits ... ok
test legacy::kernels::rolling::no_nulls::variance::test::test_rolling_var ... ok
test legacy::kernels::rolling::nulls::quantile::test::test_rolling_median_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_extrema_nulls ... ok
test legacy::kernels::rolling::nulls::quantile::test::test_rolling_quantile_nulls_limits ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_max_no_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_mean_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_sum_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_var_nulls ... ok
test legacy::kernels::rolling::window::test::test_sorted_buf ... ok
test legacy::kernels::set::test::test_set_at_idx ... ok
test legacy::kernels::set::test::test_set_mask ... ok
test legacy::kernels::sort_partition::test::test_partition_points ... ok
test legacy::kernels::test::test_binary_masked_slice_iter ... ok
test legacy::kernels::test::test_binary_slice_mask_iter_with_false ... ok
test types::native::test::test_f16_to_f32 ... ok
test array::specification::tests::check_utf8_validation ... ok
test bitmap::bitmask::test::test_nth_set_bit_u32 ... ok

test result: ok. 33 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.16s

   Doc-tests polars-arrow

running 13 tests
test crates/polars-arrow/src/bitmap/immutable.rs - bitmap::immutable::Bitmap (line 17) ... ok
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray<T>::from_vec (line 127) ... ok
test crates/polars-arrow/src/bitmap/utils/chunk_iterator/merge.rs - bitmap::utils::chunk_iterator::merge::merge_reversed (line 8) ... ignored
test crates/polars-arrow/src/array/struct_/mod.rs - array::struct_::StructArray (line 17) ... ok
test crates/polars-arrow/src/array/boolean/mod.rs - array::boolean::BooleanArray (line 32) ... ok
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray<T>::to (line 96) ... ok
test crates/polars-arrow/src/array/binary/mod.rs - array::binary::BinaryArray (line 31) ... ok
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray (line 33) ... ok
test crates/polars-arrow/src/array/utf8/mod.rs - array::utf8::Utf8Array (line 37) ... ok
test crates/polars-arrow/src/types/bit_chunk.rs - types::bit_chunk::BitChunkIter (line 56) ... ok
test crates/polars-arrow/src/bitmap/mutable.rs - bitmap::mutable::MutableBitmap (line 24) ... ok
test crates/polars-arrow/src/buffer/immutable.rs - buffer::immutable::Buffer (line 21) ... ok
test crates/polars-arrow/src/types/bit_chunk.rs - types::bit_chunk::BitChunkOnes (line 109) ... ok

test result: ok. 12 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 5.25s

ubuntu@localhost:~/git/polars/crates/polars-arrow$ git rev-parse HEAD
f5f07823ad7c1ab9ae0553bff31f1b768d3ed886

[ritchie46]

@ritchie46 , appear to be OK (assuming I was meant to run cargo test from the polars-arrow directory

cargo test --all-features

[nameexhaustion]

I get the following error repeated a few times:

29 | polars_arrow::error::Result::Ok(())
   |               ^^^^^ could not find `error` in `polars_arrow`

ubuntu@localhost:~/git/polars/crates/polars-arrow$ cargo test --all-features
warning: /home/ubuntu/git/polars/crates/polars-error/Cargo.toml: `default-features` is ignored for parquet2, since `default-features` was not specified for `workspace.dependencies.parquet2`, this could become a hard error in the future
   Compiling num-traits v0.2.16
   Compiling num-integer v0.1.45
   Compiling syn v2.0.28
   Compiling siphasher v0.3.10
   Compiling futures-channel v0.3.28
   Compiling futures-util v0.3.28
   Compiling num-bigint v0.4.4
   Compiling num-rational v0.4.1
   Compiling phf_shared v0.11.2
   Compiling num-iter v0.1.43
   Compiling anyhow v1.0.75
   Compiling lexical-util v0.8.5
   Compiling phf_generator v0.11.2
   Compiling either v1.9.0
   Compiling phf_codegen v0.11.2
   Compiling phf v0.11.2
   Compiling parse-zoneinfo v0.3.0
   Compiling itertools v0.10.5
   Compiling crc-catalog v1.1.1
   Compiling crc v2.1.0
   Compiling xxhash-rust v0.8.6
   Compiling lexical-write-integer v0.8.5
   Compiling lexical-parse-integer v0.8.6
   Compiling chrono-tz-build v0.2.0
   Compiling arrow-schema v46.0.0
   Compiling lexical-parse-float v0.8.5
   Compiling lexical-write-float v0.8.5
   Compiling chrono v0.4.31
   Compiling num-complex v0.4.4
   Compiling half v2.3.1
   Compiling prost-derive v0.11.9
   Compiling chrono-tz v0.8.3
   Compiling num-bigint v0.2.6
   Compiling lexical-core v0.8.5
   Compiling plotters v0.3.5
   Compiling atoi v2.0.0
   Compiling hex v0.4.3
   Compiling proptest v1.2.0
   Compiling num v0.4.1
   Compiling arrow-buffer v46.0.0
   Compiling arrow-data v46.0.0
   Compiling serde_derive v1.0.188
   Compiling futures-macro v0.3.28
   Compiling async-stream-impl v0.3.5
   Compiling bytemuck_derive v1.4.1
   Compiling async-trait v0.1.73
   Compiling thiserror-impl v1.0.44
   Compiling async-stream v0.3.5
   Compiling prost v0.11.9
   Compiling bytemuck v1.13.1
   Compiling tokio-macros v2.1.0
   Compiling arrow2 v0.17.4
   Compiling arrow-array v46.0.0
   Compiling thiserror v1.0.44
   Compiling tokio v1.31.0
   Compiling serde v1.0.188
   Compiling futures-executor v0.3.28
   Compiling futures v0.3.28
   Compiling parquet-format-safe v0.2.4
   Compiling sample-arrow2 v0.17.1
   Compiling tokio-util v0.7.8
   Compiling serde_json v1.0.104
   Compiling arrow-format v0.8.1
   Compiling uuid v0.8.2
   Compiling ciborium v0.2.1
   Compiling avro-schema v0.3.0
   Compiling tinytemplate v1.2.1
   Compiling avro-rs v0.13.0
   Compiling criterion v0.5.1
   Compiling parquet2 v0.17.2
   Compiling polars-error v0.33.2 (/home/ubuntu/git/polars/crates/polars-error)
   Compiling polars-arrow v0.33.2 (/home/ubuntu/git/polars/crates/polars-arrow)
    Finished test [unoptimized + debuginfo] target(s) in 1m 11s
warning: the following packages contain code that will be rejected by a future version of Rust: snap v0.2.5
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
     Running unittests src/lib.rs (/home/ubuntu/git/polars/target/debug/deps/polars_arrow-a4b0bca3e92f99c6)

running 125 tests
test bitmap::utils::chunk_iterator::merge::tests::test_merge_reversed ... ok
test bitmap::utils::chunk_iterator::merge::tests::test_merge_reversed_offset2 ... ok
test compute::arithmetics::decimal::tests::test_adjusted_precision_scale ... ok
test compute::arithmetics::decimal::tests::test_max_value ... ok
test compute::arithmetics::decimal::tests::test_number_digits ... ok
test compute::comparison::binary::tests::test_gt_eq_scalar ... ok
test compute::comparison::binary::tests::test_eq_scalar ... ok
test compute::comparison::binary::tests::test_eq ... ok
test compute::comparison::binary::tests::test_gt_eq ... ok
test compute::comparison::binary::tests::test_neq_scalar ... ok
test compute::comparison::primitive::tests::test_length_of_result_buffer ... ok
test compute::comparison::primitive::tests::test_primitive_array_compare_scalar_slice ... ok
test compute::comparison::binary::tests::test_neq ... ok
test compute::comparison::primitive::tests::test_primitive_array_compare_slice ... ok
test compute::comparison::primitive::tests::test_primitive_array_eq ... ok
test compute::comparison::primitive::tests::test_primitive_array_eq_scalar ... ok
test compute::comparison::primitive::tests::test_primitive_array_eq_with_slice ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_eq ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_eq_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_eq_scalar ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_eq_scalar_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_scalar ... ok
test compute::comparison::primitive::tests::test_primitive_array_gt_scalar_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_eq ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_eq_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_eq_scalar ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_eq_scalar_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_scalar ... ok
test compute::comparison::primitive::tests::test_primitive_array_lt_scalar_nulls ... ok
test compute::comparison::primitive::tests::test_primitive_array_neq ... ok
test compute::comparison::primitive::tests::test_primitive_array_neq_scalar ... ok
test compute::comparison::utf8::tests::test_eq ... ok
test compute::comparison::utf8::tests::test_eq_scalar ... ok
test compute::comparison::utf8::tests::test_gt_eq_scalar ... ok
test compute::comparison::utf8::tests::test_gt_eq ... ok
test compute::comparison::utf8::tests::test_neq ... ok
test compute::comparison::utf8::tests::test_neq_scalar ... ok
test compute::take::boolean::tests::all_cases ... ok
test compute::take::utf8::tests::all_cases ... ok
test io::ipc::compression::tests::round_trip_lz4 ... ok
test ffi::schema::tests::test_all ... ok
test io::parquet::read::deserialize::null::tests::limit ... ok
test io::ipc::read::common::tests::project_iter ... ok
test io::parquet::read::schema::convert::tests::test_column_desc_to_field ... ignored
test io::parquet::read::schema::convert::tests::test_byte_array_fields ... ok
test io::parquet::read::schema::convert::tests::test_duplicate_fields ... ok
test io::parquet::read::schema::convert::tests::test_nested_schema ... ok
test io::parquet::read::schema::convert::tests::test_parquet_list_nullable ... ok
test io::parquet::read::schema::convert::tests::test_field_to_column_desc ... ok
test io::parquet::read::schema::convert::tests::test_int96_options ... ok
test io::parquet::read::schema::convert::tests::test_parquet_lists ... ignored
test io::parquet::read::schema::convert::tests::test_repeated_nested_schema ... ignored
test io::parquet::read::schema::convert::tests::test_flat_primitives ... ok
test io::parquet::write::nested::def::tests::l1_required_required ... ok
test io::parquet::write::nested::def::tests::l1_optional_optional ... ok
test io::parquet::write::nested::def::tests::l2_optional_optional_required ... ok
test io::parquet::read::schema::convert::tests::test_parquet_list_with_struct ... ok
test io::parquet::write::nested::def::tests::l2_optional_optional_optional ... ok
test io::parquet::write::nested::def::tests::l2_optional_required_required ... ok
test io::ipc::compression::tests::round_trip_zstd ... ok
test io::parquet::write::nested::def::tests::nested_edge_simple ... ok
test io::parquet::write::nested::def::tests::l2_required_required_required ... ok
test io::parquet::write::nested::def::tests::nested_list_struct_list_nullable ... ok
test io::parquet::write::nested::def::tests::nested_list_struct_list_nullable1 ... ok
test io::parquet::write::nested::def::tests::nested_list_struct_nullable ... ok
test io::parquet::write::nested::def::tests::nested_list_struct_nullable1 ... ok
test io::parquet::write::nested::def::tests::nested_struct_list_nullable ... ok
test io::parquet::write::nested::def::tests::nested_struct_list_nullable1 ... ok
test io::parquet::write::nested::def::tests::struct_optional ... ok
test io::parquet::write::nested::def::tests::struct_optional_1 ... ok
test io::parquet::write::nested::def::tests::struct_optional_optional ... ok
test io::parquet::write::nested::rep::tests::l1 ... ok
test io::parquet::write::nested::rep::tests::l2 ... ok
test io::parquet::write::nested::rep::tests::l2_other ... ok
test io::parquet::write::nested::rep::tests::list_of_struct ... ok
test io::parquet::write::nested::rep::tests::list_struct_list ... ok
test io::parquet::write::nested::rep::tests::list_struct_list_1 ... ok
test io::parquet::write::nested::rep::tests::list_struct_list_2 ... ok
test io::parquet::write::nested::rep::tests::list_struct_list_3 ... ok
test io::parquet::write::nested::rep::tests::struct_list_optional ... ok
test io::parquet::write::nested::rep::tests::struct_optional ... ok
test io::parquet::write::nested::rep::tests::struct_required ... ok
test io::parquet::write::pages::tests::test_list_struct ... ok
test io::parquet::write::pages::tests::test_map ... ok
test io::parquet::write::pages::tests::test_struct ... ok
test io::parquet::write::pages::tests::test_struct_struct ... ok
test legacy::compute::decimal::test::test_decimal ... ok
test legacy::kernels::ewm::average::test::test_ewm_mean_with_null ... ok
test legacy::compute::take::test::test_utf8_kernel ... ok
test legacy::kernels::ewm::average::test::test_ewm_mean_without_null ... ok
test legacy::kernels::ewm::variance::test::test_ewm_min_periods ... ok
test legacy::kernels::ewm::variance::test::test_ewm_cov ... ok
test legacy::kernels::list::test::test_sublist_get ... ok
test legacy::kernels::ewm::variance::test::test_ewm_var ... ok
test legacy::kernels::rolling::no_nulls::quantile::test::test_rolling_median ... ok
test legacy::kernels::rolling::no_nulls::quantile::test::test_rolling_quantile_limits ... ok
test legacy::kernels::rolling::no_nulls::min_max::test::test_rolling_min_max ... ok
test legacy::kernels::rolling::no_nulls::sum::test::test_rolling_sum ... ok
test legacy::kernels::rolling::no_nulls::variance::test::test_rolling_var ... ok
test legacy::kernels::list::test::test_sublist_get_indexes ... ok
test legacy::kernels::rolling::nulls::quantile::test::test_rolling_median_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_extrema_nulls ... ok
test legacy::kernels::rolling::nulls::quantile::test::test_rolling_quantile_nulls_limits ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_sum_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_mean_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_max_no_nulls ... ok
test legacy::kernels::rolling::nulls::test::test_rolling_var_nulls ... ok
test legacy::kernels::rolling::window::test::test_sorted_buf ... ok
test legacy::kernels::set::test::test_set_at_idx ... ok
test legacy::kernels::sorted_join::inner::test::test_inner_join ... ok
test legacy::kernels::sorted_join::left::test::test_left_join ... ok
test legacy::kernels::test::test_binary_masked_slice_iter ... ok
test legacy::kernels::test::test_binary_slice_mask_iter_with_false ... ok
test types::native::test::test_f16_to_f32 ... ok
test types::simd::packed::tests::test_basic1 ... ok
test types::simd::packed::tests::test_basic2 ... ok
test legacy::kernels::sort_partition::test::test_partition_points ... ok
test legacy::kernels::set::test::test_set_mask ... ok
test legacy::kernels::ewm::variance::test::test_ewm_std ... ok
test array::specification::tests::check_utf8_validation ... ok
test bitmap::bitmask::test::test_nth_set_bit_u32 ... ok

test result: ok. 122 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out; finished in 0.18s

   Doc-tests polars-arrow

running 102 tests
test crates/polars-arrow/src/array/utf8/mod.rs - array::utf8::Utf8Array (line 37) ... ok
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray (line 33) ... ok
test crates/polars-arrow/src/bitmap/utils/chunk_iterator/merge.rs - bitmap::utils::chunk_iterator::merge::merge_reversed (line 8) ... ignored
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray<T>::from_vec (line 127) ... ok
test crates/polars-arrow/src/array/binary/mod.rs - array::binary::BinaryArray (line 31) ... ok
test crates/polars-arrow/src/array/primitive/mod.rs - array::primitive::PrimitiveArray<T>::to (line 96) ... ok
test crates/polars-arrow/src/array/struct_/mod.rs - array::struct_::StructArray (line 17) ... ok
test crates/polars-arrow/src/bitmap/immutable.rs - bitmap::immutable::Bitmap (line 17) ... ok
test crates/polars-arrow/src/array/boolean/mod.rs - array::boolean::BooleanArray (line 32) ... ok
test crates/polars-arrow/src/bitmap/mutable.rs - bitmap::mutable::MutableBitmap (line 24) ... ok
test crates/polars-arrow/src/buffer/immutable.rs - buffer::immutable::Buffer (line 21) ... ok
test crates/polars-arrow/src/compute/aggregate/min_max.rs - compute::aggregate::min_max::max_boolean (line 286) ... ok
test crates/polars-arrow/src/compute/aggregate/min_max.rs - compute::aggregate::min_max::min_boolean (line 258) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::add (line 21) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::checked_add (line 65) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::add_scalar (line 189) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::checked_add_scalar (line 231) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::overflowing_add (line 114) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::overflowing_add_scalar (line 280) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::saturating_add_scalar (line 255) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::saturating_add (line 89) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::wrapping_add_scalar (line 210) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/div.rs - compute::arithmetics::basic::div::checked_div (line 52) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/div.rs - compute::arithmetics::basic::div::checked_div_scalar (line 166) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/add.rs - compute::arithmetics::basic::add::wrapping_add (line 42) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/div.rs - compute::arithmetics::basic::div::div (line 20) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/div.rs - compute::arithmetics::basic::div::div_scalar (line 94) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mod.rs - compute::arithmetics::basic::checked_negate (line 66) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mod.rs - compute::arithmetics::basic::negate (line 47) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mod.rs - compute::arithmetics::basic::wrapping_negate (line 86) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::mul (line 21) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::checked_mul (line 66) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::checked_mul_scalar (line 232) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::mul_scalar (line 190) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::overflowing_mul_scalar (line 281) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::saturating_mul (line 90) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::overflowing_mul (line 115) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::saturating_mul_scalar (line 256) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::wrapping_mul (line 42) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/mul.rs - compute::arithmetics::basic::mul::wrapping_mul_scalar (line 211) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/pow.rs - compute::arithmetics::basic::pow::checked_powf_scalar (line 33) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/pow.rs - compute::arithmetics::basic::pow::powf_scalar (line 12) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/rem.rs - compute::arithmetics::basic::rem::checked_rem_scalar (line 161) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/rem.rs - compute::arithmetics::basic::rem::rem (line 18) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/rem.rs - compute::arithmetics::basic::rem::checked_rem (line 40) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/rem.rs - compute::arithmetics::basic::rem::rem_scalar (line 81) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::checked_sub (line 65) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::checked_sub_scalar (line 231) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::overflowing_sub (line 114) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::overflowing_sub_scalar (line 280) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::wrapping_sub (line 42) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::saturating_sub (line 89) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::sub (line 21) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::saturating_sub_scalar (line 255) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::wrapping_sub_scalar (line 210) ... ok
test crates/polars-arrow/src/compute/arithmetics/basic/sub.rs - compute::arithmetics::basic::sub::sub_scalar (line 189) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/add.rs - compute::arithmetics::decimal::add::adaptive_add (line 150) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/add.rs - compute::arithmetics::decimal::add::checked_add (line 86) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/div.rs - compute::arithmetics::decimal::div::adaptive_div (line 226) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/div.rs - compute::arithmetics::decimal::div::saturating_div (line 115) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/div.rs - compute::arithmetics::decimal::div::checked_div (line 164) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/mul.rs - compute::arithmetics::decimal::mul::adaptive_mul (line 238) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/add.rs - compute::arithmetics::decimal::add::saturating_add (line 42) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/div.rs - compute::arithmetics::decimal::div::div (line 21) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/mul.rs - compute::arithmetics::decimal::mul::checked_mul (line 169) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/mul.rs - compute::arithmetics::decimal::mul::mul (line 20) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/sub.rs - compute::arithmetics::decimal::sub::saturating_sub (line 57) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/mul.rs - compute::arithmetics::decimal::mul::saturating_mul (line 119) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::and (line 40) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::all (line 267) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/sub.rs - compute::arithmetics::decimal::sub::adaptive_sub (line 166) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/sub.rs - compute::arithmetics::decimal::sub::sub (line 18) ... ok
test crates/polars-arrow/src/compute/arithmetics/decimal/sub.rs - compute::arithmetics::decimal::sub::checked_sub (line 123) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::any (line 238) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::and_scalar (line 184) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::is_not_null (line 161) ... ok
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::all (line 276) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::not (line 123) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::is_null (line 139) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::or (line 82) ... ok
test crates/polars-arrow/src/compute/boolean.rs - compute::boolean::or_scalar (line 209) ... ok
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::and (line 95) ... ok
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::and_scalar (line 207) ... ok
test crates/polars-arrow/src/compute/filter.rs - compute::filter::filter (line 255) ... FAILED
test crates/polars-arrow/src/compute/if_then_else.rs - compute::if_then_else::if_then_else (line 10) ... FAILED
test crates/polars-arrow/src/compute/comparison/mod.rs - compute::comparison (line 16) ... ok
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::or (line 12) ... ok
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::any (line 242) ... ok
test crates/polars-arrow/src/io/ipc/mod.rs - io::ipc (line 31) ... FAILED
test crates/polars-arrow/src/io/ipc/write/file_async.rs - io::ipc::write::file_async::FileSink (line 27) ... FAILED
test crates/polars-arrow/src/io/ipc/write/stream_async.rs - io::ipc::write::stream_async::StreamSink (line 23) ... FAILED
test crates/polars-arrow/src/compute/boolean_kleene.rs - compute::boolean_kleene::or_scalar (line 175) ... ok
test crates/polars-arrow/src/io/parquet/write/sink.rs - io::parquet::write::sink::FileSink (line 24) ... FAILED
test crates/polars-arrow/src/compute/comparison/mod.rs - compute::comparison (line 38) ... ok
test crates/polars-arrow/src/compute/comparison/mod.rs - compute::comparison (line 27) ... ok
test crates/polars-arrow/src/compute/concatenate.rs - compute::concatenate (line 5) ... ok
test crates/polars-arrow/src/compute/take/mod.rs - compute::take::can_take (line 96) ... ok
test crates/polars-arrow/src/compute/temporal.rs - compute::temporal::can_hour (line 373) ... ok
test crates/polars-arrow/src/compute/temporal.rs - compute::temporal::can_year (line 332) ... ok
test crates/polars-arrow/src/io/parquet/write/mod.rs - io::parquet::write::transverse (line 857) ... ok
test crates/polars-arrow/src/types/bit_chunk.rs - types::bit_chunk::BitChunkIter (line 56) ... ok
test crates/polars-arrow/src/types/bit_chunk.rs - types::bit_chunk::BitChunkOnes (line 109) ... ok

failures:

---- crates/polars-arrow/src/compute/filter.rs - compute::filter::filter (line 255) stdout ----
error[E0432]: unresolved import `polars_arrow::error`
 --> crates/polars-arrow/src/compute/filter.rs:258:19
  |
5 | use polars_arrow::error::Result;
  |                   ^^^^^ could not find `error` in `polars_arrow`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
Couldn't compile the test.
---- crates/polars-arrow/src/compute/if_then_else.rs - compute::if_then_else::if_then_else (line 10) stdout ----
error[E0432]: unresolved import `polars_arrow::error`
 --> crates/polars-arrow/src/compute/if_then_else.rs:12:19
  |
4 | use polars_arrow::error::Result;
  |                   ^^^^^ could not find `error` in `polars_arrow`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
Couldn't compile the test.
---- crates/polars-arrow/src/io/ipc/mod.rs - io::ipc (line 31) stdout ----
error[E0432]: unresolved import `polars_arrow::error`
  --> crates/polars-arrow/src/io/ipc/mod.rs:38:19
   |
10 | use polars_arrow::error::Error;
   |                   ^^^^^ could not find `error` in `polars_arrow`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
Couldn't compile the test.
---- crates/polars-arrow/src/io/ipc/write/file_async.rs - io::ipc::write::file_async::FileSink (line 27) stdout ----
error[E0433]: failed to resolve: could not find `error` in `polars_arrow`
  --> crates/polars-arrow/src/io/ipc/write/file_async.rs:62:15
   |
38 | polars_arrow::error::Result::Ok(())
   |               ^^^^^ could not find `error` in `polars_arrow`
   |
help: consider importing one of these items
   |
2  + use arrow_format::flight::data::Result;
   |
2  + use core::fmt::Result;
   |
2  + use core::result::Result;
   |
2  + use futures::io::Result;
   |
     and 10 other candidates
help: if you import `Result`, refer to it directly
   |
38 - polars_arrow::error::Result::Ok(())
38 + Result::Ok(())
   |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
Couldn't compile the test.
---- crates/polars-arrow/src/io/ipc/write/stream_async.rs - io::ipc::write::stream_async::StreamSink (line 23) stdout ----
error[E0433]: failed to resolve: could not find `error` in `polars_arrow`
  --> crates/polars-arrow/src/io/ipc/write/stream_async.rs:49:15
   |
29 | polars_arrow::error::Result::Ok(())
   |               ^^^^^ could not find `error` in `polars_arrow`
   |
help: consider importing one of these items
   |
2  + use arrow_format::flight::data::Result;
   |
2  + use core::fmt::Result;
   |
2  + use core::result::Result;
   |
2  + use futures::io::Result;
   |
     and 10 other candidates
help: if you import `Result`, refer to it directly
   |
29 - polars_arrow::error::Result::Ok(())
29 + Result::Ok(())
   |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
Couldn't compile the test.
---- crates/polars-arrow/src/io/parquet/write/sink.rs - io::parquet::write::sink::FileSink (line 24) stdout ----
error[E0433]: failed to resolve: could not find `error` in `polars_arrow`
  --> crates/polars-arrow/src/io/parquet/write/sink.rs:60:15
   |
39 | polars_arrow::error::Result::Ok(())
   |               ^^^^^ could not find `error` in `polars_arrow`
   |
help: consider importing one of these items
   |
2  + use arrow_format::flight::data::Result;
   |
2  + use core::fmt::Result;
   |
2  + use core::result::Result;
   |
2  + use futures::io::Result;
   |
     and 10 other candidates
help: if you import `Result`, refer to it directly
   |
39 - polars_arrow::error::Result::Ok(())
39 + Result::Ok(())
   |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
Couldn't compile the test.

failures:
    crates/polars-arrow/src/compute/filter.rs - compute::filter::filter (line 255)
    crates/polars-arrow/src/compute/if_then_else.rs - compute::if_then_else::if_then_else (line 10)
    crates/polars-arrow/src/io/ipc/mod.rs - io::ipc (line 31)
    crates/polars-arrow/src/io/ipc/write/file_async.rs - io::ipc::write::file_async::FileSink (line 27)
    crates/polars-arrow/src/io/ipc/write/stream_async.rs - io::ipc::write::stream_async::StreamSink (line 23)
    crates/polars-arrow/src/io/parquet/write/sink.rs - io::parquet::write::sink::FileSink (line 24)

test result: FAILED. 95 passed; 6 failed; 1 ignored; 0 measured; 0 filtered out; finished in 185.05s

error: doctest failed, to rerun pass `--doc`

[ritchie46]

Yes, that's the doctests. We still need to fix those.

In any case, the default tests look good. 👍 Thanks!