chore(python): Enable the isort-style import autofix via ruff
#6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
approved these changes
Jan 3, 2023
|
Ruff is actually good at autofixing all kind of stuff. Enabling isort is a good start - we should probably look into what else it can autofix, without it being annoying. |
ritchie46
changed the title
isort-style import autofix via ruffisort-style import autofix via ruff
github-actions
bot
added
chore
Indeed! I figured we should start small and work our way up... :) |
KivalM
pushed a commit
to rohit-ptl/polars
that referenced
this pull request
Jan 4, 2023
zundertj
pushed a commit
to zundertj/polars
that referenced
this pull request
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were detecting it, but not acting on it.
With
fixenabled, thefixablelist constrains what it will attempt to autofix.Before (example)
After