Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live updates and sorting for R data explorer #287

Merged
merged 43 commits into from
Apr 3, 2024
Merged

Live updates and sorting for R data explorer #287

Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
ff9dd6c
add test for data updates
jmcphers Mar 27, 2024
a439df2
use 'attr' as accessor for attributes
jmcphers Mar 28, 2024
a9453fe
Merge remote-tracking branch 'origin/main' into feature/data-explorer…
jmcphers Mar 28, 2024
b33b214
pass an optional variable binding into the data explorer
jmcphers Mar 28, 2024
a16fc2c
listen for prompt signals; emit updates when data changes
jmcphers Mar 28, 2024
3102325
supply a binding in data explorer test
jmcphers Mar 28, 2024
1ed7d1f
add a test for schema level updates
jmcphers Mar 28, 2024
1e659c8
store column schema in a cache
jmcphers Mar 29, 2024
34d180d
test for schema vs. data update
jmcphers Mar 29, 2024
6c2a49f
add test for refreshed schema
jmcphers Mar 29, 2024
30ad29d
Merge remote-tracking branch 'origin/main' into feature/data-explorer…
jmcphers Mar 29, 2024
a709a6d
store current set of sort keys
jmcphers Mar 29, 2024
0d434a1
super basic sorting implementation
jmcphers Mar 29, 2024
78817e7
reset row indices after clearing sorting
jmcphers Mar 29, 2024
65480b6
support for ascending/descending sorting
jmcphers Mar 29, 2024
09227e4
add unit test for Vec<bool> conversion
jmcphers Apr 1, 2024
460203b
add a test to cover multi column sort and descending sort
jmcphers Apr 1, 2024
c8e20a3
ensure sorting also affects row labels
jmcphers Apr 1, 2024
a317f70
implement and test sorting by matrix column
jmcphers Apr 1, 2024
28ce156
Merge remote-tracking branch 'origin/main' into feature/data-explorer…
jmcphers Apr 1, 2024
03bb91d
re-sort data after detecting a change
jmcphers Apr 1, 2024
8dd0955
close the comm when binding goes away
jmcphers Apr 1, 2024
cee26b4
omit length when computing column type names
jmcphers Apr 1, 2024
20dd0f1
Merge remote-tracking branch 'origin/main' into feature/data-explorer…
jmcphers Apr 2, 2024
9eb3bc3
clean up unused imports
jmcphers Apr 2, 2024
7216ee3
simplify construction of bool vector
jmcphers Apr 2, 2024
76801bc
better naming for info about object's name/env
jmcphers Apr 2, 2024
eef64a1
simplify ternary expression
jmcphers Apr 2, 2024
f52d9fa
specify radix sort
jmcphers Apr 2, 2024
216221e
protect result of update check
jmcphers Apr 2, 2024
bf01f7a
use [[ to extract columns from data frames
jmcphers Apr 2, 2024
8ceb87f
implement null count summary stats
jmcphers Apr 2, 2024
b00ea6f
Extract first test in a reusable function
lionel- Apr 3, 2024
c0c1e45
Test data explorer with a tibble
lionel- Apr 3, 2024
e8bc98a
Clean up tibble after test
lionel- Apr 3, 2024
cf43115
Update crates/ark/src/data_explorer/r_data_explorer.rs
jmcphers Apr 3, 2024
db0e77c
simplify null/NA counting
jmcphers Apr 3, 2024
007eabd
Merge remote-tracking branch 'origin/main' into feature/data-explorer…
jmcphers Apr 3, 2024
d1d59a4
monitor variable for updates even if provided via View()
jmcphers Apr 3, 2024
a7aa213
simplify object name derivation
jmcphers Apr 3, 2024
1c05603
convert indices to 1-based at the FFI boundary
jmcphers Apr 3, 2024
609d14a
clarify behavior of initial row population
jmcphers Apr 3, 2024
22ec3bd
Update crates/harp/src/object.rs
jmcphers Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading