Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation of introducing cached wheels that are not zips. The
Wheel
struct has a lot of responsibilities (installing, metadata, lazy metadata, vitals), I wanted to simplify it so that it represents just a zipped.whl
file.I changed the API by moving a lot of the functionality associated with wheels out of
Wheel
and into their own functions.install_wheel
) is no longer an associated function. I did this because in the future Ill change the API to also be able to install cached wheels. I also moved this to its own module. It seemed appropriate.get_vitals()
. This function was extracting data from a.whl
that was used in different places. The metadata was used by the packagedatabase and some other fields where used during installing. Neither usecases required all data so I split it up and moved the extraction to where it was actually used.get_metadata
is still part ofWheel
.lazy_read_metadata
. This function had nothing to do withWheel
. I moved it to its own function.