Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify Wheel API #231

Merged
merged 4 commits into from
Feb 19, 2024
Merged

refactor: simplify Wheel API #231

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
977e2b4
refactor: simplify wheel API
baszalmstra Feb 18, 2024
887e73b
fix: unix issue
baszalmstra Feb 18, 2024
b02323c
fix: consist renaming of unpacking to installing
baszalmstra Feb 18, 2024
08f2848
fix: add missing snapshot
baszalmstra Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: unix issue
  • Loading branch information
@baszalmstra
baszalmstra committed Feb 18, 2024
commit 887e73b923e8b0a4589e9816af9a59b2540b3306
4 changes: 2 additions & 2 deletions crates/rattler_installs_packages/src/install/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
}
}

/// Additional optional settings to pass to [`Wheel::unpack`].

Check failure on line 80 in crates/rattler_installs_packages/src/install/mod.rs

View workflow job for this annotation

GitHub Actions / Check intra-doc links 

unresolved link to `Wheel::unpack`
///
/// Not all options in this struct are relevant. Typically you will default a number of fields.
#[derive(Default)]
Expand Down Expand Up @@ -702,7 +702,7 @@

#[cfg(unix)]
{
use fs::os::unix::fs::OpenOptionsExt;
use std::os::unix::fs::OpenOptionsExt;
if _executable {
options.mode(0o777);
} else {
Expand Down Expand Up @@ -740,7 +740,7 @@
options.write(true).create(true);
#[cfg(unix)]
{
use fs::os::unix::fs::OpenOptionsExt;
use std::os::unix::fs::OpenOptionsExt;
if _executable {
options.mode(0o777);
} else {
Expand Down
Loading