Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update size tokens to Primitives pre-v8 release #2425

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

langermank
Copy link
Contributor

What are you trying to accomplish?

  • Import the new set of size tokens and rename (remove --primer prefix)

What approach did you choose and why?

Find/replace

Can these changes ship as is?

⚠️ This same change will need to be made in PVC, and then both version bumped in dotcom with additional find/replace name changes

@langermank langermank requested a review from a team as a code owner April 21, 2023 16:12
@langermank langermank requested a review from rezrah April 21, 2023 16:12
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: c6bde3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to github-pages April 21, 2023 16:47 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview April 21, 2023 16:48 Inactive
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@langermank langermank merged commit 718f1aa into main Apr 21, 2023
@langermank langermank deleted the upgrade-primitives-size-tokens branch April 21, 2023 17:03
@primer-css primer-css mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants