Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Primitives and rename tokens to pre-v8 release #1964

Merged
merged 14 commits into from
Apr 21, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Apr 21, 2023

Description

  • Import the new set of size tokens and rename (remove --primer prefix)

Integration

Does this change require any updates to code in production?

This PR depends on primer/css#2425 and the next PCSS release, which will be bumped in this PR. More name changes will need to be made in dotcom.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@langermank langermank requested a review from a team as a code owner April 21, 2023 16:36
@langermank langermank requested review from a team, simurai and keithamus April 21, 2023 16:36
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: cdd6fe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Apr 21, 2023
@langermank langermank marked this pull request as draft April 21, 2023 16:43
@langermank langermank temporarily deployed to preview April 21, 2023 17:44 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank temporarily deployed to preview April 21, 2023 17:58 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 21, 2023
@langermank langermank temporarily deployed to preview April 21, 2023 18:25 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages April 21, 2023 18:31 — with GitHub Actions Inactive
@langermank langermank merged commit d6a4605 into main Apr 21, 2023
@langermank langermank deleted the update-primitives-pre-v8 branch April 21, 2023 20:17
@primer-css primer-css mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants