Upgrade to latest stylelint 16 and make esm the default module format #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e9e74c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Changes look good from the CommonJS -> ESM perspective! Let me know when you want an official review once this is ready to review 👀 I think the only thing that could come up is around subpath imports (or requires) and if that changes with this update. |
langermank
approved these changes
Apr 16, 2024
Merged
jonrohan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's goal is to update to the latest version of Stylelint.
In order to do this, it requires that we upgrade the package to using ESModules. This needed a bit of rewriting happening in some of the plugins. The majority of changes were needed in how we import in each plugin. To do so without breaking backwards compatibility we introduced
rollupto include.cjscommon js imports.There was also an upgrade of
eslintneeded to support the new formats.