Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundle): add rollup for emitting CommonJS and ESM #398

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(bundle): add rollup for emitting CommonJS and ESM #398

merged 1 commit into from
Apr 15, 2024

Conversation

joshblack
Copy link
Member

Add a bundle step to the package to emit ESM and CommonJS entry points. These are referenced in the exports config in package.json under the import and require conditions, respectively.

@joshblack joshblack requested a review from a team as a code owner April 15, 2024 16:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: d461dec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack requested review from jonrohan and removed request for tobiasahlin April 15, 2024 16:47
jonrohan
jonrohan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻

@jonrohan jonrohan merged commit 530aa8a into upgrade_stylelint Apr 15, 2024
3 of 4 checks passed
@jonrohan jonrohan deleted the feat/add-rollup-for-cjs-output branch April 15, 2024 16:48
jonrohan added a commit that referenced this pull request Apr 16, 2024
@jonrohan @joshblack
Upgrade to latest stylelint and make esm the default module format (#397
255a3c4 
)

* Upgrade to latest stylelint and make esm the default module format

* upgrade prettier

* Fixing eslint problems

* simplify jest config

* Remove node version 16

* Update imports

* Create wicked-cobras-juggle.md

* feat(bundle): add rollup for emitting CommonJS and ESM (#398)

* Include dist folder

* update canary job

* Try importing plugins

* Adjust imports for rollup and eslint problems

* Test fixes

* Reduce to minor release

* Use const experimentalVars

* Remove extra comment

* Remove require from plugin

* Move to dependency

* Fix no-override to use all primer

* Remove no experimental vars

* Use with and change parser to typescript

* Update wicked-cobras-juggle.md

* Create proud-ducks-retire.md

---------

Co-authored-by: Josh Black <joshblack@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @jonrohan