Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Primitives and rename tokens to pre-v8 release #1964

Merged
merged 14 commits into from
Apr 21, 2023
Merged

Upgrade Primitives and rename tokens to pre-v8 release #1964

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ba61ed9
update size token names
langermank Apr 21, 2023
5ffb276
bump pcss
langermank Apr 21, 2023
d20a1ea
Create twelve-badgers-beg.md
langermank Apr 21, 2023
57f98db
fix path
langermank Apr 21, 2023
2ff7658
remove actionlist
langermank Apr 21, 2023
62eb8f5
Merge branch 'update-primitives-pre-v8' of https://github.com/primer/…
langermank Apr 21, 2023
3cc9877
Generating component snapshots
langermank Apr 21, 2023
d880172
fix CSS for autocomplete actionlist
langermank Apr 21, 2023
6f32b9e
Merge branch 'update-primitives-pre-v8' of https://github.com/primer/…
langermank Apr 21, 2023
1521b1d
Generating component snapshots
langermank Apr 21, 2023
6bd6080
fix autocomplete css
langermank Apr 21, 2023
2180cb0
Merge branch 'update-primitives-pre-v8' of https://github.com/primer/…
langermank Apr 21, 2023
cc44c62
Fix AutoComplete tests
camertron Apr 21, 2023
cdd6fe3
Fix AutoComplete system tests
camertron Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix AutoComplete system tests
  • Loading branch information
@camertron
camertron committed Apr 21, 2023
commit cdd6fe3430f553a66df74794f31654b51eb55f61
8 changes: 4 additions & 4 deletions test/system/beta/auto_complete_component_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ def test_renders_component

assert_selector("auto-complete[for=\"list-id\"][src=\"/auto_complete\"]") do
assert_selector("input.FormControl-input")
assert_selector("ul[id=\"list-id\"].ActionList", visible: false)
assert_selector("ul[id=\"list-id\"].ActionListWrap", visible: false)
end
refute_selector(".ActionList-item")
refute_selector(".ActionListItem")
end

def test_search_items
Expand All @@ -21,8 +21,8 @@ def test_search_items
fill_in "input-id", with: "a"

# results are now visible
assert_selector("ul[id=\"list-id\"].ActionList", visible: true)
assert_selector(".ActionList-item")
assert_selector("ul[id=\"list-id\"].ActionListWrap", visible: true)
assert_selector(".ActionListItem")
end

def test_renders_non_visible_label
Expand Down