Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action list description test selector #2984

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jul 30, 2024

See: #2971 (thanks @sampart!)

What are you trying to accomplish?

Make it possible to set a test_selector on Primer::Alpha::ActionList::Item#description.

Screenshots

screenshot with devtools open, showing the test selector

Integration

No changes necessary in production.

List the issues that this change affects.

Closes #2970

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

After discussing with @camertron (thank you!) I went for switching from a passthrough slot to a lambda slot, returning a Primer::BaseComponent so that it can be used with with_content as well as with a block.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: 09b20bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron force-pushed the action_list_description_test_selector branch from 38476f4 to 09b20bd Compare July 30, 2024 21:58
@camertron camertron marked this pull request as ready for review July 30, 2024 21:59
@camertron camertron requested a review from a team as a code owner July 30, 2024 21:59
Copy link
Contributor

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camertron camertron merged commit c56f325 into main Aug 1, 2024
39 checks passed
@camertron camertron deleted the action_list_description_test_selector branch August 1, 2024 17:14
@primer primer bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set a test_selector on Primer::Alpha::Item#description
2 participants