Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action list description test selector #2984

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Action list description test selector #2984

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba44f1f
Allow ActionList::Item#description to accept a test selector
sampart Jul 19, 2024
6740642
Update preview to use test_selector
sampart Jul 26, 2024
d3578f1
Give it the right classes
sampart Jul 26, 2024
c9c8257
Improve comment
sampart Jul 30, 2024
055983c
Merge remote-tracking branch 'sampart/action-list-item-description-te…
camertron Jul 30, 2024
ca19830
Add changeset
camertron Jul 30, 2024
19f151f
Add test
camertron Jul 30, 2024
09b20bd
Add docs
camertron Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give it the right classes
  • Loading branch information
@sampart
sampart committed Jul 26, 2024
commit d3578f1a2bb04ce961a205b97d1fcd430913bee5
2 changes: 1 addition & 1 deletion app/components/primer/alpha/action_list/item.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Item < Primer::Component
# Description content that complements the item's label. See `ActionList`'s `description_scheme` argument
# for layout options.
renders_one :description, -> (test_selector: nil) do
Primer::BaseComponent.new(tag: "span", test_selector: test_selector) { content }
Primer::BaseComponent.new(tag: "span", classes: "ActionListItem-description", test_selector: test_selector) { content }
end

# An icon, avatar, SVG, or custom content that will render to the left of the label.
Expand Down
Loading