This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
Drop gRPC support #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knative does not (yet) support gRPC. Since only HTTP is supported, including any other protocol is pure overhead. Once Knative Serving has support for gRPC, we'll restore support here. Even then, Knative Eventing will use a different proto, so the existing gRPC support wouldn't work anyway. The facilities for supporting multiple protocols remain in place, even though only HTTP is supported at the moment. Fixes projectriff#65
|
Merged as f9e1b9b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knative does not (yet) support gRPC. Since only HTTP is supported,
including any other protocol is pure overhead. Once Knative Serving has
support for gRPC, we'll restore support here. Even then, Knative
Eventing will use a different proto, so the existing gRPC support
wouldn't work anyway.
The facilities for supporting multiple protocols remain in place, even
though only HTTP is supported at the moment.
Fixes #65