make tls option InsecureSkipVerify configurable by alertmanager #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PLEASE don't close and open a new pull request because CI fails. You can restart CI. This creates a ton of noise and is very annoying. |
|
Sorry for that... |
|
I was very much hoping we could get the entire HTTP config a la this, to make sure everything we know being a valid use case can be enabled. But we never go to agreement on how to continue. /cc @fabxc @brian-brazil |
|
Closed by #1528 |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 26, 2018
* Change Dfly's CPU counting frequency, see: prometheus/node_exporter#1129 * Convert Dfly's CPU unit into second Signed-off-by: iori-yja <fivo.11235813@gmail.com>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 30, 2018
* Change Dfly's CPU counting frequency, see: prometheus/node_exporter#1129 * Convert Dfly's CPU unit into second Signed-off-by: iori-yja <fivo.11235813@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to send mails to notify clients, and if it requires TLS, the TLS option InsecureSkipVerify should be configurable with alertmanager's configuration. This PR is to add InsecureSkipVerify into alertmanager's global configuration.