feat(email): support custom TLS certificates #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use the existing TLSConfig from common rather than doing things by hand. |
|
@brian-brazil from common ? |
|
Yes, that's the one. |
mxinden
reviewed
Aug 27, 2018
config/notifiers.go
Outdated
| @@ -163,6 +163,9 @@ type EmailConfig struct { | |||
| HTML string `yaml:"html,omitempty" json:"html,omitempty"` | |||
| Text string `yaml:"text,omitempty" json:"text,omitempty"` | |||
| RequireTLS *bool `yaml:"require_tls,omitempty" json:"require_tls,omitempty"` | |||
| TLSCA string `yaml:"tls_ca,omitempty" json:"tls_ca,omitempty"` | |||
There was a problem hiding this comment.
Instead of injecting these into the EmailConfig struct, I think @brian-brazil was referring to use TLSConfig from the common package.
There was a problem hiding this comment.
Just understand, you want I use the TLSConfig struct instead of 3 strings in EmailConfig
but server name will be redundant
There was a problem hiding this comment.
I don't see why server_name would be redundant, the DNS name you're using may not match the tls cert the server itself knows about.
|
Better ? |
Signed-off-by: miton18 <remi+github@collignon-ducret.fr>
|
Is it OK for you ? |
|
Thx ! |
This was referenced Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.