Allow slashes in receivers #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It looks like the code has been like that forever but I can't think of a justification for it. Maybe @stuartnelson3 has some thoughts? |
|
Can't think of anything. Seems fine to me |
I'm not sure why this was originally done, because a slash seems to be perfectly valid in a receiver definition. The only issue i encountered was that linking from a fired alert was not working, because of the splitting performed here. Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
If Receiver is allowed to contain slashes and other special characters we need to percent encode them properly. Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
simonpasquier
force-pushed
the
allow-slashes-in-receivers-for-urls
branch
from
80c4995
to
e1dbd30
Compare
Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that alertmanager was splitting the
Receiverin templates by the first slash and only exposing the value prior to this first slash.I couldn't find out whether there was a particular reason for this as
Receivers with slashes seem to be working well within every other part of the alertmanager.Changes:
Receiverwithin the default alertmanager URL.