Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow slashes in receivers #2011

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Allow slashes in receivers #2011

merged 3 commits into from
Aug 28, 2019

Commits on Aug 27, 2019

  1. do not split receiver by slash 

    I'm not sure why this was originally done, because a slash seems to be perfectly
valid in a receiver definition. The only issue i encountered was that linking
from a fired alert was not working, because of the splitting performed here.

Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
    @0robustus1 @simonpasquier
    0robustus1 authored and simonpasquier committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    34e3d29 View commit details
    Browse the repository at this point in the history

  2. urlquery escape Receiver by default for URL 

    If Receiver is allowed to contain slashes and other special characters
we need to percent encode them properly.

Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
    @0robustus1 @simonpasquier
    0robustus1 authored and simonpasquier committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    e1dbd30 View commit details
    Browse the repository at this point in the history

  3. rerun make asset/assets_vfsdata.go 

    Signed-off-by: Tim Reddehase <tim.reddehase@xing.com>
    @0robustus1
    0robustus1 committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    6286647 View commit details
    Browse the repository at this point in the history