-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaffeinate spec/ci-spec
#21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this PR looks great, just some simple changes requested, otherwise lets get it merged!
}) | ||
|
||
afterEach(() => { | ||
var done = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var done = false | |
let done = false |
response.sendFile(path.join(__dirname, 'fixtures', 'native-module-1.0.0.tgz')) | ||
}) | ||
server = http.createServer(app) | ||
var live = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var live = false | |
let live = false |
response.sendFile(path.join(__dirname, 'fixtures', 'native-module-1.0.0.tgz')) | ||
}) | ||
server = http.createServer(app) | ||
var live = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var live = false | |
let live = false |
const apm = require('../lib/apm-cli') | ||
|
||
describe('apm ci', () => { | ||
var server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var server | |
let server |
Supposedly superseeded by #65 |
Since I work on many files, I edit
package.json
to add useful shortcut to avoid misspelt filename.Steps to reproduce decaffeination (guidelines):
npx coffee --compile --output spec spec/ci-spec.coffee
./bin/npm run test-decaff --name=ci-spec
)var
withconst
andlet
if it's possible.return
when it's not needed.coffee
fileTest from coffee and JS should output same successful result :
From coffee
to js