Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate ci spec #65

Merged
merged 7 commits into from
May 19, 2023

Conversation

2colours
Copy link
Contributor

No description provided.

@2colours 2colours marked this pull request as ready for review March 28, 2023 18:52
@2colours 2colours mentioned this pull request Mar 28, 2023
12 tasks
@2colours
Copy link
Contributor Author

Supersedes #21.

unused occurrances of request changed to _request, and one rather shouldn't require JSON files so reading it synchronously.

@confused-Techie
Copy link
Member

@2colours One question I have concerns about, since the decaf PRs will be merged to main, will it cause issues that they are all separate PRs? Since these changes would be totally fine to be all on one PR.

@2colours
Copy link
Contributor Author

@confused-Techie I'm doing it like this for one simple reason: this is how @GuilleW left it behind. I can just checkout the branch, rebase it to the new one, play around with the differences that happened on main in the meantime... but you are right, probably the end result should be a decaf branch where everything is decaffeinated. Which is, I think, where these PR's will lead.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this PR looks good, there's one change that should be made, as it's generally the more performant option, and another change I wanted to address prior to merging.

Otherwise the tests are currently running and fingers crossed they look good, appreciate this a ton @2colours and sorry this last one took a bit to get to

spec/ci-spec.js Outdated Show resolved Hide resolved
spec/ci-spec.js Show resolved Hide resolved
spec/ci-spec.js Outdated Show resolved Hide resolved
- config path resolution based on file location
- eliminate unnecessary variables along with the initialization
@2colours 2colours mentioned this pull request Apr 8, 2023
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the important tests passing, and the changes here looking good I'll merge this one to the decaf branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants