WIP: recursive type unrolling prototype

[t0yv0]

Preview applying pulumi/pulumi-terraform-bridge#2134

[iwahbe]

Spot checking, this makes sense.

[iwahbe]

Is this just better shortening? It sounds like it should be RuleGroupRuleStatementMatchStatementFieldToMatch, since the rule statement appears in types nested from multiple properties of RuleGroupRuleStatement.

[t0yv0]

Yeah ugh, shorter token heuristic picked this. I'd like to try to give it a better name.

[t0yv0]

Couple of problems here.

tfgen is non-deterministic with substitutions like this one:

•    sqliMatchStatement?: pulumi.Input<inputs.wafv2.RuleGroupRuleStatementRegexMatchStatement>;
  

•    sqliMatchStatement?: pulumi.Input<inputs.wafv2.RuleGroupRuleStatementSizeConstraintStatement>;
  

These two types should not be have been picked for rewrite I suspect, and it's strange that one or the other is picked, I'd expect A<B or B<A on these.

     export interface RuleGroupRuleStatementRegexMatchStatement {
        /**
         * The part of a web request that you want AWS WAF to inspect. See Field to Match below for details.
         */
        fieldToMatch?: pulumi.Input<inputs.wafv2.RuleGroupRuleStatementRegexMatchStatementFieldToMatch>;
        /**
         * The string representing the regular expression. **Note:** The fixed quota for the maximum number of characters in each regex pattern is 200, which can't be changed. See [AWS WAF quotas](https://docs.aws.amazon.com/waf/latest/developerguide/limits.html) for details.
         */
        regexString: pulumi.Input<string>;
        /**
         * Text transformations eliminate some of the unusual formatting that attackers use in web requests in an effort to bypass detection.
         * At least one required.
         * See Text Transformation below for details.
         */
        textTransformations: pulumi.Input<pulumi.Input<inputs.wafv2.RuleGroupRuleStatementRegexMatchStatementTextTransformation>[]>;
    }


    export interface RuleGroupRuleStatementSizeConstraintStatement {
        /**
         * The operator to use to compare the request part to the size setting. Valid values include: `EQ`, `NE`, `LE`, `LT`, `GE`, or `GT`.
         */
        comparisonOperator: pulumi.Input<string>;
        /**
         * The part of a web request that you want AWS WAF to inspect. See Field to Match below for details.
         */
        fieldToMatch?: pulumi.Input<inputs.wafv2.RuleGroupRuleStatementSizeConstraintStatementFieldToMatch>;
        /**
         * The size, in bytes, to compare to the request part, after any transformations. Valid values are integers between 0 and 21474836480, inclusive.
         */
        size: pulumi.Input<number>;
        /**
         * Text transformations eliminate some of the unusual formatting that attackers use in web requests in an effort to bypass detection.
         * At least one required.
         * See Text Transformation below for details.
         */
        textTransformations: pulumi.Input<pulumi.Input<inputs.wafv2.RuleGroupRuleStatementSizeConstraintStatementTextTransformation>[]>;
    }

With

    export interface RuleGroupRuleStatementSqliMatchStatement {
        /**
         * The part of a web request that you want AWS WAF to inspect. See Field to Match below for details.
         */
        fieldToMatch?: pulumi.Input<inputs.wafv2.RuleGroupRuleStatementSqliMatchStatementFieldToMatch>;
        /**
         * Text transformations eliminate some of the unusual formatting that attackers use in web requests in an effort to bypass detection.
         * At least one required.
         * See Text Transformation below for details.
         */
        textTransformations: pulumi.Input<pulumi.Input<inputs.wafv2.RuleGroupRuleStatementSqliMatchStatementTextTransformation>[]>;
    }