WIP: Detect recursive type unrolling #2134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2134 +/- ##
==========================================
+ Coverage 60.64% 62.52% +1.88%
==========================================
Files 350 355 +5
Lines 45793 38677 -7116
==========================================
- Hits 27770 24183 -3587
+ Misses 16491 12909 -3582
- Partials 1532 1585 +53 ☔ View full report in Codecov by Sentry. |
t0yv0
commented
Jun 26, 2024
| // | ||
| // Suppose ancestor(T1, T2) if T2 describes a sub-property of T1. | ||
| // | ||
| // Suppose T1 <= T2 if T1 has the subset of properties of T2 with types that are themselves Tx <= Ty. |
There was a problem hiding this comment.
This seems to work really well for the AWS WAFv2 example at least.
t0yv0
commented
Jun 26, 2024
t0yv0
commented
Jun 26, 2024
iwahbe
reviewed
Jun 26, 2024
| return "", false | ||
| } | ||
| cleanRef := strings.TrimPrefix(rawRef, "#/types/") | ||
| return tokens.Type(cleanRef), true |
There was a problem hiding this comment.
Is there a reason not to validate here?
Suggested change
| return tokens.Type(cleanRef), true | |
| typ, err := tokens.ParseTypeToken(cleanRef) | |
| contract.AssertNoErrorf(err, "invalid schema") | |
| return typ, true |
| return best | ||
| } | ||
|
|
||
| func findGenericTypeReferences(x any) (typeRefs, error) { |
There was a problem hiding this comment.
It feels like this could be implemented via type_visitor.go and it would be much easer to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.