-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import resources with provider default tags #4169
Changes from 1 commit
276cafb
e573c99
0063967
18cc1c4
892e985
e24dbfa
7852b77
28ff3a5
9095918
6a9f36c
5f51229
54a9732
25b4b15
d4c01b7
185f434
e84e096
5fe2ef0
8c72e64
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Upgrade pu/pu to 3.124.0
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,12 +71,40 @@ func main() { | |
return err | ||
} | ||
|
||
env, err := appconfig.NewEnvironment(ctx, "testappconfigenv"+testIdent, &appconfig.EnvironmentArgs{ | ||
ApplicationId: app.ID(), | ||
Tags: tagsMap, | ||
}, pulumi.Provider(p)) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
getEnv, err := appconfig.GetEnvironment(ctx, "get-testappconfigenv"+testIdent, env.ID(), &appconfig.EnvironmentState{}, pulumi.Provider(p)) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
// refresh doesn't work for `forceDelete` & `acl` uncomment when fixed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is interesting, is this something worth linking a ticket to? Thank you. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added another comment with link to the issue. |
||
// getBucket, err := s3.GetBucketV2(ctx, "get-bucketv2"+testIdent, bucket.ID(), &s3.BucketV2State{}, pulumi.Provider(p), pulumi.IgnoreChanges([]string{"forceDestroy", "acl"})) | ||
// if err != nil { | ||
// return err | ||
// } | ||
// getLegacyBucket, err := s3.GetBucket(ctx, "get-legacybucket"+testIdent, legacyBucket.ID(), &s3.BucketState{}, pulumi.Provider(p), pulumi.IgnoreChanges([]string{"forceDestroy", "acl"})) | ||
// if err != nil { | ||
// return err | ||
// } | ||
|
||
ctx.Export("bucket", exportTags(bucket.Tags)) | ||
// ctx.Export("get-bucket", exportTags(getBucket.Tags)) | ||
ctx.Export("legacy-bucket", exportTags(legacyBucket.Tags)) | ||
// ctx.Export("get-legacy-bucket", exportTags(getLegacyBucket.Tags)) | ||
ctx.Export("bucket-name", bucket.Bucket) | ||
ctx.Export("legacy-bucket-name", legacyBucket.Bucket) | ||
ctx.Export("appconfig-app", exportTags(app.Tags)) | ||
ctx.Export("appconfig-app-arn", app.Arn) | ||
ctx.Export("appconfig-env", exportTags(env.Tags)) | ||
ctx.Export("get-appconfig-env", exportTags(getEnv.Tags)) | ||
ctx.Export("appconfig-env-arn", env.Arn) | ||
|
||
return nil | ||
}) | ||
|
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these comments still useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added another comment with link to the issue. When the issue is fixed the code can be uncommented.