Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import resources with provider default tags #4169

Merged
merged 18 commits into from
Jul 23, 2024
Merged

Fix import resources with provider default tags #4169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
276cafb
Fix import resources with provider default tags
corymhall Jul 3, 2024
e573c99
skip test
corymhall Jul 3, 2024
0063967
fixing test
corymhall Jul 3, 2024
18cc1c4
Adding more tests
corymhall Jul 10, 2024
892e985
Merge remote-tracking branch 'origin/master' into corymhall/default-t…
corymhall Jul 10, 2024
e24dbfa
Add a note
corymhall Jul 10, 2024
7852b77
trying to fix upstream
corymhall Jul 10, 2024
28ff3a5
run go mod tidy
corymhall Jul 10, 2024
9095918
adding parallel to tests
corymhall Jul 11, 2024
6a9f36c
Merge branch 'master' into corymhall/default-tags-import
corymhall Jul 15, 2024
5f51229
Fixing tests
corymhall Jul 15, 2024
54a9732
fixing spelling
corymhall Jul 15, 2024
25b4b15
adding pf tests to some additional tags tests
corymhall Jul 18, 2024
d4c01b7
Merge remote-tracking branch 'origin/master' into corymhall/default-t…
corymhall Jul 18, 2024
185f434
adding test for .get methods
corymhall Jul 18, 2024
e84e096
run go mod tidy
corymhall Jul 18, 2024
5fe2ef0
Merge branch 'master' into corymhall/default-tags-import
corymhall Jul 23, 2024
8c72e64
updating based on comments
corymhall Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
updating based on comments
  • Loading branch information
@corymhall
corymhall committed Jul 23, 2024
commit 8c72e647cdad57ba0e339984603f4cfd8a12da38
2 changes: 2 additions & 0 deletions examples/examples_go_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ func (st tagsState) validateStateResult(phase int) func(
t.Logf("key=%s tags are as expected: %v", k, actualTagsJSON)

if k == "bucket" {
// TODO: uncomment when https://github.com/pulumi/pulumi-aws/issues/4258 is fixed
// getTags := stack.Outputs["get-bucket"].(string)
// assert.Equal(t, v.(string), getTags)
bucketName := stack.Outputs["bucket-name"].(string)
Expand All @@ -259,6 +260,7 @@ func (st tagsState) validateStateResult(phase int) func(
"bad bucket tags")
}
if k == "legacy-bucket" {
// TODO: uncomment when https://github.com/pulumi/pulumi-aws/issues/4258 is fixed
// getTags := stack.Outputs["get-legacy-bucket"].(string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments still useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another comment with link to the issue. When the issue is fixed the code can be uncommented.

// assert.Equal(t, v.(string), getTags)
bucketName := stack.Outputs["legacy-bucket-name"].(string)
Expand Down
3 changes: 2 additions & 1 deletion examples/tags-combinations-go/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ func main() {
return err
}

// refresh doesn't work for `forceDelete` & `acl` uncomment when fixed
// TODO: uncomment when https://github.com/pulumi/pulumi-aws/issues/4258 is fixed
// refresh doesn't work for `forceDelete` & `acl`
// getBucket, err := s3.GetBucketV2(ctx, "get-bucketv2"+testIdent, bucket.ID(), &s3.BucketV2State{}, pulumi.Provider(p), pulumi.IgnoreChanges([]string{"forceDestroy", "acl"}))
// if err != nil {
// return err
Expand Down
3 changes: 2 additions & 1 deletion examples/tags-combinations-go/step1/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ func main() {
return err
}

// refresh doesn't work for `forceDelete` & `acl` uncomment when fixed
// TODO: uncomment when https://github.com/pulumi/pulumi-aws/issues/4258 is fixed
// refresh doesn't work for `forceDelete` & `acl`
// getBucket, err := s3.GetBucketV2(ctx, "get-bucketv2"+testIdent, bucket.ID(), &s3.BucketV2State{}, pulumi.Provider(p))
// if err != nil {
// return err
Expand Down
2 changes: 1 addition & 1 deletion provider/provider_yaml_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ func TestAccDefaultTags(t *testing.T) {
})
bucketName := outputs["id"].Value.(string)
tags := getBucketTagging(context.Background(), bucketName)
assert.Subset(t, tags, []types.Tag{
assert.Equal(t, tags, []types.Tag{
{
Key: pulumi.StringRef("LocalTag"),
Value: pulumi.StringRef("foo"),
Expand Down
Loading