First Draft of the User Module #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to follow the naming convention (#13) used for modules, we should rename the new user module to |
Closed
KiLLuuuhh
force-pushed
the
add/user_module
branch
from
378a95e
to
4ac160a
Compare
|
this resolves #50 |
KiLLuuuhh
force-pushed
the
add/user_module
branch
from
4f122cf
to
7aa5eaa
Compare
rekup
reviewed
Apr 12, 2024
tests/unit/plugins/module_utils/test_system_access_users_utils.py
Outdated
Show resolved
Hide resolved
rekup
reviewed
Apr 12, 2024
rekup
reviewed
Apr 12, 2024
KiLLuuuhh
force-pushed
the
add/user_module
branch
2 times, most recently
from
78348ba
to
043396b
Compare
Co-authored-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
force-pushed
the
add/user_module
branch
from
f909828
to
ba6ccfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the User Module with the following capabilities:
While I welcome comprehensive feedback on the entire module, there are three functions in particular where I'd appreciate more focused and detailed review:
I wanted to give the user the opportunity to set custom apikeys. However, to check the validity of the key, I only used a length validation. I hope to get some feedback from you to handle this case properly. Please consider also, how I handle the generation of the key, if None is provided. Regarding the apikey there is another uncertainty: If no key is provided, one is generated and could be returned to the user. I handled this using a new result attribute "apikeys" in the
system_access_users.pyfile.Please let me know, if additional tests must be implemented.
Note on Exclusion of "Certificates" Attribute:
I would like to point out that I consciously excluded the "certificates" attribute from this iteration of the user module. This decision was based on the fact, that when the checkbox is checked in the GUI, the User is redirected to the certificate page. The system_trust_certificates module is considered a seperate module in our Roadmap: #41