initial version of the system_settings_logging module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiLLuuuhh
requested changes
Mar 21, 2024
rekup
force-pushed
the
feat/system_settings_logging
branch
from
a39d4f2
to
8760271
Compare
ombre8
reviewed
Mar 23, 2024
rekup
force-pushed
the
feat/system_settings_logging
branch
3 times, most recently
from
342e3f8
to
4e70208
Compare
KiLLuuuhh
approved these changes
Apr 15, 2024
Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
rekup
force-pushed
the
feat/system_settings_logging
branch
from
7b79c88
to
a444d66
Compare
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 16, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 16, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 16, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 17, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 17, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
that referenced
this pull request
Apr 17, 2024
* updated tests * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup * applied suggestions from @rekup (introduced salted secrets) * ensured correct error handling as @rekup suggested * ensured correct error handling as @rekup suggested * excluded tests from pylint * fixed linter error * fixed last linter erros * added pylinter exception for crypt since this library is used in the core OPNsense and there is no build-in alternative at this time * reformted code * updated docstring methods * updated default value for shell * ran black * changed default shell to /sbin/nologin * added fully qualifed names to the converge file * updated error handling * fixed argument * Update plugins/module_utils/system_access_users_utils.py Co-authored-by: Reto Kupferschmid <kupferschmid@puzzle.ch> * black errors * fixed typo * reformat * initial version of the system_settings_logging module (#61) * initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com> * fixed module_index * fixed module_index * added 2.15 sanity ignore * added 2.16 sanity ignore * added devel sanity ignore * updated devel test * updated devel test python versions * removed sanity ignores * added debug.msg to return apikeys if created * refactored hash_secret creation * added unhashed secret to result * ran black * impemented hash function * removed unused function * removed unused function * added some validation and error handling to _generate_hashed_secret * refactored error * added three tests to confirm functionality of _generate_hashed_secret --------- Co-authored-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 17, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 17, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 20, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 20, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 22, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 22, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 22, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 22, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 23, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
to KiLLuuuhh/puzzle.opnsense
that referenced
this pull request
Apr 23, 2024
* initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com>
KiLLuuuhh
added a commit
that referenced
this pull request
Apr 23, 2024
* first draft of converge file * first draft of the molecule file * fixed typo * fixed module naming * first draft of the utils * added first draft of plugins/module_utils/interfaces_assignments_utils.py * added first draft of plugins/modules/interfaces_assignments.py * added first draft of plugins/module_utils/module_index.py * added missing function * updated interfaces_assignments.py * updated converge.yml * finished tests * updated converge.yml * updated interfaces_assignments_utils.py * added verify file * updated module_index * updated interfaces_assignments * removed old file * updated tests * updated typo in tests * updated tests * added docstring to Interface_assignment class * added docstring to Interface_assignment functions * added class- and docstring to class InterfacesSet * updated linter errors * updated linter errors * updated linter errors * some more linter erros * fixed typo * excluded tests from linter * some linter changes + comparision fixed * added full config as test xml * fixed RETURN * fixed RETURN * some more linter errors * sanity error fix * XML Utility: elements_equal (#86) * Drop ansible core devel python 3.7 support * Make dict_to_etree exception more verbose * Add elements_equal xml utility * Lint xml utils sequence bool check * Format changes * initial version of the system_settings_logging module (#61) * initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com> * updated linter errors * XML Utility: elements_equal (#86) * Drop ansible core devel python 3.7 support * Make dict_to_etree exception more verbose * Add elements_equal xml utility * Lint xml utils sequence bool check * Format changes * updated module_index * initial version of the system_settings_logging module (#61) * initial version of the system_settings_logging module --------- Co-authored-by: KiLLuuuhh <74672908+KiLLuuuhh@users.noreply.github.com> * updated module_index * added pylint: disable=duplicate-code * updated converge tests * updated unit tests * changed error message * added fail_json exceptions * updated utils, so that local interfaces can be queried and created logic for interface update * updated module_index * updated test contexts * refactored some code for the linter * fixed list error * black * added some tests * added new error * fixed typing issue * fixed doc issue * added fully qualified collection names * removed OPNSenseInterfaceNotFoundError * applied DonGiovannis suggestions * removed InterfaceNotFound error since it is not used * restructured get_interfaces method to not rely on removed interfaces_list module_index entry * removed unused entries * removed unused interfaces_list entry * some more module_index updates * Update plugins/modules/interfaces_assignments.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * Update plugins/module_utils/interfaces_assignments_utils.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * Update plugins/module_utils/module_index.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * Update plugins/module_utils/module_index.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * Update plugins/module_utils/module_index.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * Update plugins/module_utils/module_index.py Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> * updated error texts * applied DonGiovanni suggestions * refactored code * reimplements configure_params * final adjustments * finalized module_index * updated get_interfaces so that it uses the newly created run_command function * updated tests * black plugins/module_utils/interfaces_assignments_utils.py * restructed module_index --------- Co-authored-by: Fabio Bertagna <33524186+DonGiovanni83@users.noreply.github.com> Co-authored-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52
Depends on the following PRs: