Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use
module.fail_json
in our modules, this will cause our config managers__exit__
function to raise an exception. This will cause Ansible to display a warning (Module invocation had junk after the JSON data
):This is probably ok if the error was caused by an unhandled exception, but it's not what we expect if we handle an error in our module and deliberately call
module.fail_json
. This PR fixes the by raising anySystemExit
exceptions "as is" which enables Ansible to correctly recognize the call tomodule.fail_json
without displaying the warning.