Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version logic #93

Merged
merged 1 commit into from
Apr 15, 2024
Merged

update version logic #93

merged 1 commit into from
Apr 15, 2024

Conversation

rekup
Copy link
Contributor

@rekup rekup commented Apr 15, 2024

  • make the opnsense version a public attribute of the OPNsenseModuleConfig class
  • make get_opnsense_version return the plain version

@rekup rekup requested a review from KiLLuuuhh April 15, 2024 10:59
@rekup rekup mentioned this pull request Apr 15, 2024
Merged
KiLLuuuhh
KiLLuuuhh approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@KiLLuuuhh KiLLuuuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rekup rekup merged commit e0f7e55 into puzzle:main Apr 15, 2024
36 checks passed
KiLLuuuhh pushed a commit to KiLLuuuhh/puzzle.opnsense that referenced this pull request Apr 15, 2024
@rekup @KiLLuuuhh
update version logic (puzzle#93)
f9cfc02
KiLLuuuhh pushed a commit to KiLLuuuhh/puzzle.opnsense that referenced this pull request Apr 16, 2024
@rekup @KiLLuuuhh
update version logic (puzzle#93)
6ffc260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiLLuuuhh KiLLuuuhh KiLLuuuhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekup @KiLLuuuhh