Use strict optional checking in misc.py #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things to change here: First, I think the StreamWrapper code was buggy and it meant to patch an instance, not the class. It probably doesn't show up in practice because the encodings are the same. Second, urlparse's hostname can be None. While this isn't likely, I chose to put it in the signature rather than assert. I then need one assert when something from it gets added to `self.pip_trusted_origins` in another file. `self.pip_trusted_origins` genuinely assumes that hostname is not None, so the assert seemed fine.
pfmoore
reviewed
Aug 16, 2022
uranusjr
approved these changes
Aug 16, 2022
|
Bump! :-) |
|
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things to change here:
First, I think the StreamWrapper code was buggy and it meant to patch an
instance, not the class. It probably doesn't show up in practice because
the encodings are the same.
Second, urlparse's hostname can be None. While this isn't likely, I
chose to put it in the signature rather than assert. I then need one
assert when something from it gets added to
self.pip_trusted_originsin another file.
self.pip_trusted_originsgenuinely assumes thathostname is not None, so the assert seemed fine.