Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict optional checking in misc.py #11382

Merged
merged 6 commits into from
Jul 17, 2023

Commits on Aug 16, 2022

  1. Use strict optional checking in misc.py

    Two things to change here:
    
    First, I think the StreamWrapper code was buggy and it meant to patch an
    instance, not the class. It probably doesn't show up in practice because
    the encodings are the same.
    
    Second, urlparse's hostname can be None. While this isn't likely, I
    chose to put it in the signature rather than assert. I then need one
    assert when something from it gets added to `self.pip_trusted_origins`
    in another file. `self.pip_trusted_origins` genuinely assumes that
    hostname is not None, so the assert seemed fine.
    hauntsaninja committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9262def View commit details
    Browse the repository at this point in the history
  2. fix ci

    hauntsaninja committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d21832e View commit details
    Browse the repository at this point in the history
  3. validate host

    hauntsaninja committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    4b1bd7f View commit details
    Browse the repository at this point in the history
  4. fixup

    hauntsaninja committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    69cf232 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Configuration menu
    Copy the full SHA
    f28c704 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    bfbec5b View commit details
    Browse the repository at this point in the history