Simplify requirement file parsing #7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clears the way and for us to create our parser outside the function next.
Simplifies reading the code that actually processes the line.
comes_from is only used in get_file_content, which expects to see a URL or path, so there is no need to decorate it.
This change makes factoring out the parsing more obvious.
Decouples `process_lines` from our CLI options.
chrahunt
added
type: refactor
|
Bump |
pradyunsg
approved these changes
Oct 25, 2019
|
(moved this out of "Build logic refactor", since IMO this isn't directly related how pip builds a distribution) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of a cleanup and refactoring of our requirement file parsing.
The general goal is to decouple the file/line parsing from the construction of the requirements objects. To that end, this PR reduces coupling between a few components and moves the parsing-specific logic to one place in
process_lineso that the extraction will be easier to review.This PR does not go all the way to extract the parsing logic because many tests in
tests.unit.test_req_filerely on the current interface. I'd rather bundle those into their own change.