Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify requirement file parsing #7245

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Simplify requirement file parsing #7245

merged 5 commits into from
Oct 25, 2019

Commits on Oct 20, 2019

  1. Do not create line-specific parsers for requirements files 

    This clears the way and for us to create our parser outside
the function next.
    @chrahunt
    chrahunt committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    6645530 View commit details
    Browse the repository at this point in the history

  2. Hide line parsing details behind a line parser 

    Simplifies reading the code that actually processes the line.
    @chrahunt
    chrahunt committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    f0b20f1 View commit details
    Browse the repository at this point in the history

  3. Remove no-action TODO 

    comes_from is only used in get_file_content, which expects to see a URL
or path, so there is no need to decorate it.
    @chrahunt
    chrahunt committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    4d7fc27 View commit details
    Browse the repository at this point in the history

  4. Do requirement file recursion first 

    This change makes factoring out the parsing more obvious.
    @chrahunt
    chrahunt committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    c830761 View commit details
    Browse the repository at this point in the history

  5. Simplify skip_requirements_regex option handling 

    Decouples `process_lines` from our CLI options.
    @chrahunt
    chrahunt committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    a5d53ea View commit details
    Browse the repository at this point in the history