Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deprecation warning for libpysal geometries #649

Merged
merged 3 commits into from
Sep 19, 2021
Merged

add deprecation warning for libpysal geometries #649

merged 3 commits into from
Sep 19, 2021

Conversation

jGaboardi
Copy link
Member

This PR kicks of the process of deprecating libpysal geometries and overhauling spaghetti.

xref: #646 (comment), Refactor spaghetti

@jGaboardi jGaboardi self-assigned this Sep 14, 2021
@jGaboardi
Copy link
Member Author

Gentle ping on this @martinfleis. If you have a few minutes, I think it should be a quick review.

martinfleis
martinfleis reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would raise a FutureWarning rather than DeprecationWarning. Then you don't even need to call simplefilter.

  2. This message can be super cryptic. We should also add information answering what does it mean from user perspective and what should I do to prepare.

martinfleis
martinfleis reviewed Sep 19, 2021
View reviewed changes
spaghetti/network.py Outdated Show resolved Hide resolved
@jGaboardi @martinfleis
Update spaghetti/network.py
3bc0e4e 
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
martinfleis
martinfleis approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ready to go. It may get a bit annoying but I am not sure we have a better option.

@jGaboardi jGaboardi merged commit ee17b8e into pysal:main Sep 19, 2021
@jGaboardi jGaboardi deleted the depre_note branch September 19, 2021 15:36
@jGaboardi jGaboardi mentioned this pull request May 15, 2022
Merged
@p91g p91g mentioned this pull request Feb 3, 2023
Closed
@wsqstar wsqstar mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @martinfleis