Fix AttrsInstance protocol check with cache
#14551
Conversation
This comment has been minimized.
This comment has been minimized.
| [file m.py.2] | ||
| import attr | ||
| from c import Entry | ||
|
|
||
| def func(e: Entry) -> int: | ||
| attr.asdict(e) | ||
| return 2 |
There was a problem hiding this comment.
The fix does work when tested locally. However, I couldn't reproduce it with this test case although I though I should be able to. Maybe the cache isn't serialized for it?
Open to ideas how to fix the test case.
There was a problem hiding this comment.
I was able to reproduce with types-attrs. Maybe try revendoring the attr fixture from typeshed from before python/typeshed#5585 ?
There was a problem hiding this comment.
I believe we already use a custom stub for the test from test-data/unit/lib-stub/attr. That shouldn't be the issue, I think.
Rather the problem only happens if c.py is deserialized from cache and I'm not sure that is happing here. Might be that just both c.py and m.py.2 get analyzed in the second run in which case the error won't show up.
There was a problem hiding this comment.
@hauntsaninja Got it working 🎉 Moving AttrsInstance from lib-stub to the test file did the job. Without the change in plugins/attrs.py, the test case is now failing.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
…14551) Use correct fullname for `__attrs_attrs__` ClassVar to fix issue with warm cache. Closes python#14099 (cherry picked from commit 8e9f89a)
Use correct fullname for
__attrs_attrs__ClassVar to fix issue with warm cache.Closes #14099