Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete attrs #5585

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Delete attrs #5585

merged 3 commits into from
Jun 8, 2021

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jun 6, 2021 •
edited
Loading

Fixes #5581

@Akuli
Copy link
Collaborator Author

Akuli commented Jun 6, 2021

Maybe we should first discuss about possible gotchas in the issue.

@Akuli Akuli marked this pull request as draft June 6, 2021 15:45
srittau
srittau approved these changes Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pypi has the latest version: https://pypi.org/project/types-attrs/ Unless something comes up, this is ready to be removed.

@srittau srittau marked this pull request as ready for review June 8, 2021 14:02
@srittau srittau merged commit 63fd168 into python:master Jun 8, 2021
@Akuli Akuli deleted the bye-attrs branch June 8, 2021 15:01
@hauntsaninja hauntsaninja mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove attrs (March 2019)
2 participants
@Akuli @srittau