Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize UPLOAD_CHANNEL #1037

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Parameterize UPLOAD_CHANNEL #1037

merged 3 commits into from
Oct 15, 2020

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Oct 14, 2020 •
edited
Loading

Package locations are hard-coded in CCI configuration.
This PR changes them to use UPLOAD_CHANNEL so that in release/* branch and release tag, they go to release location.

@mthrok mthrok mentioned this pull request Oct 14, 2020
Merged
@mthrok mthrok force-pushed the tweak-upload-channels branch 4 times, most recently from 313a65d to faddd51 Compare October 14, 2020 18:22
@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #1037 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1037   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          45       45           
  Lines        3068     3068           
=======================================
  Hits         2358     2358           
  Misses        710      710

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2775b...9b96a9d. Read the comment docs.

@mthrok mthrok changed the base branch from release/0.8 to master October 14, 2020 19:19
seemethere
seemethere reviewed Oct 15, 2020
View reviewed changes
packaging/pkg_helpers.bash Outdated Show resolved Hide resolved
packaging/pkg_helpers.bash Outdated Show resolved Hide resolved
@mthrok mthrok merged commit 135f23c into pytorch:master Oct 15, 2020
@mthrok mthrok deleted the tweak-upload-channels branch October 15, 2020 20:16
@mthrok
Copy link
Contributor Author

mthrok commented Oct 15, 2020

Thanks!

This was referenced Oct 15, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthrok @seemethere