Update unittest and packaging to use UPLOAD_CHANNEL #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
changed the title
mthrok
force-pushed
the
update-unittest
branch
from
532a5ce
to
b6e2a98
Compare
seemethere
approved these changes
Oct 20, 2020
mthrok
added a commit
to mthrok/vision
that referenced
this pull request
Oct 20, 2020
fmassa
added a commit
that referenced
this pull request
Oct 21, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
…ytorch#2848) Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
…ytorch#2848) Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes CCI configuration and packaging/unittest scripts to use
UPLOAD_CHANNELenv var to select where PyTorch-core package is coming from.This will allow the release branch to run tests on PyTorch 1.7.0-RC. The binary build was using PyTorch 1.7.0-RC so it is fine, but this PR also changes the package script to use UPLOAD_CHANNEL, instead of mixing
testandnightlychannels. Ref: pytorch/text#1037 (comment)NOTE This commit should be also cherry-picked to
masterbranch so that we do not have to repeat the process in the future release.