Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(luacheck) filter out unnecessary lines #192

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

xwen-winnie
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 4994386
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/667568671c88920008228be3

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.38%. Comparing base (c4ca1ce) to head (98f1918).

Current head 98f1918 differs from pull request most recent head c55f903

Please upload reports for the commit c55f903 to get more accurate results.

Files Patch % Lines
internal/linters/lua/luacheck/luacheck.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   36.31%   36.38%   +0.07%     
==========================================
  Files          10       10              
  Lines         873      874       +1     
==========================================
+ Hits          317      318       +1     
  Misses        528      528              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xwen-winnie xwen-winnie force-pushed the xwen2024062001 branch 2 times, most recently from 7362ada to 893f4fc Compare June 20, 2024 08:10
@xwen-winnie xwen-winnie force-pushed the xwen2024062001 branch 6 times, most recently from a699941 to e6e5b69 Compare June 21, 2024 04:00
Copy link

qiniu-x bot commented Jun 21, 2024

[Git-flow] Hi @xwen-winnie, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'master' of github.com:qiniu/reviewbot into xwen2024062001

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@xwen-winnie xwen-winnie force-pushed the xwen2024062001 branch 4 times, most recently from 98cb105 to 2e75653 Compare June 21, 2024 11:43
@CarlJi CarlJi merged commit 12bb428 into qiniu:master Jun 21, 2024
6 of 7 checks passed
This was referenced Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants