Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MCU-specific overrides for SPI flags. #17650

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Allow MCU-specific overrides for SPI flags. #17650

merged 1 commit into from
Jul 13, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 13, 2022

Description

Mainly to address things like #15389, will extrapolate for I2C and the like once we get confirmation of functionality.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 13, 2022 03:27
@github-actions github-actions bot added the core label Jul 13, 2022
@tzarc tzarc mentioned this pull request Jul 13, 2022
Closed
14 tasks
@itarze
Copy link
Contributor

itarze commented Jul 13, 2022

@tzarc I thought you handled it well. Thank you so much for taking care of my troubles.

@itarze itarze mentioned this pull request Jul 13, 2022
Merged
@drashna drashna requested a review from a team July 13, 2022 03:53
@tzarc tzarc merged commit dfff040 into qmk:develop Jul 13, 2022
@tzarc tzarc deleted the revisit-15389 branch July 13, 2022 04:42
@tzarc tzarc mentioned this pull request Jul 13, 2022
Merged
14 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @nolanseaton
Allow MCU-specific overrides for SPI flags. (qmk#17650)
c92d0d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @itarze @drashna