Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CORTEX_ENABLE_WFI_IDLE from keyboards. #21353

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Remove CORTEX_ENABLE_WFI_IDLE from keyboards. #21353

merged 2 commits into from
Jun 23, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jun 23, 2023

Description

As per the title.
Adds the equivalent to the ChibiOS build scripts.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team June 23, 2023 11:38
@zvecr zvecr merged commit 416af01 into qmk:develop Jun 23, 2023
1 of 3 checks passed
@tzarc tzarc deleted the feature/CORTEX_ENABLE_WFI_IDLE branch June 23, 2023 22:32
@lesshonor lesshonor mentioned this pull request Jul 2, 2023
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request Jul 6, 2023
Merged
14 tasks
@waffle87 waffle87 mentioned this pull request Jul 25, 2023
Closed
14 tasks
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@tzarc @jesperhellberg
Remove CORTEX_ENABLE_WFI_IDLE from keyboards. (qmk#21353)
12a4963 
* Remove CORTEX_ENABLE_WFI_IDLE from the codebase.

* Turn on CORTEX_ENABLE_WFI_IDLE by default.
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@tzarc @thismarvin
Remove CORTEX_ENABLE_WFI_IDLE from keyboards. (qmk#21353)
285e637 
* Remove CORTEX_ENABLE_WFI_IDLE from the codebase.

* Turn on CORTEX_ENABLE_WFI_IDLE by default.
@lesshonor lesshonor mentioned this pull request Sep 30, 2023
Merged
14 tasks
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@tzarc @akeep
Remove CORTEX_ENABLE_WFI_IDLE from keyboards. (qmk#21353)
0e315fc 
* Remove CORTEX_ENABLE_WFI_IDLE from the codebase.

* Turn on CORTEX_ENABLE_WFI_IDLE by default.
dhruvinsh added a commit to dhruvinsh/celeste that referenced this pull request Oct 25, 2023
@dhruvinsh
fix(config): upstream changes, ChibiOS qmk/qmk_firmware#21353
675c5df
@hellmind
Copy link

hellmind commented Nov 4, 2023

From this 416af01
I got my boot times super slow.
kinesis/kint41

@fauxpark
Copy link
Member

fauxpark commented Nov 4, 2023

This PR wouldn't have changed anything to do with that.

@hellmind
Copy link

hellmind commented Nov 6, 2023

It seems my teensy 4.1 with that change is discovering using wifi or something like that at boot.

@fauxpark
Copy link
Member

fauxpark commented Nov 6, 2023

That's not at all what this does. The Teensy 4.1 has no Wifi. Your issue is elsewhere.

@qmk qmk locked as off-topic and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tzarc @hellmind @fauxpark @zvecr