Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for encoders and support ENCODER_MAP_ENABLE on Planck rev7 #23967

Merged
merged 9 commits into from
Jul 7, 2024
Merged

Fix for encoders and support ENCODER_MAP_ENABLE on Planck rev7 #23967

merged 9 commits into from
Jul 7, 2024

Conversation

ykeisuke
Copy link

@ykeisuke ykeisuke commented Jun 20, 2024 •
edited
Loading

Description

  • Fix for encoders on Planck rev7
  • Support ENCODER_MAP_ENABLE feature on Planck rev7
  • Update readme.md on Planck rev7

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (update)
  • Keymap/layout/userspace (update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ykeisuke ykeisuke changed the base branch from master to develop June 20, 2024 17:16
drashna
drashna requested changes Jun 20, 2024
View reviewed changes
keyboards/planck/rev7/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/rev7/matrix.c Outdated Show resolved Hide resolved
keyboards/planck/rev7/matrix.c Outdated Show resolved Hide resolved
keyboards/planck/rev7/matrix.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team June 20, 2024 18:00
@ykeisuke ykeisuke requested a review from drashna June 23, 2024 03:58
@ykeisuke ykeisuke force-pushed the fix/planck-v7-with-encoder branch 3 times, most recently from c81492d to f52be72 Compare June 24, 2024 13:47
@github-actions github-actions bot added the core label Jun 25, 2024
@github-actions github-actions bot removed the core label Jun 25, 2024
@ykeisuke ykeisuke requested review from tzarc and sigprof June 26, 2024 01:55
@ykeisuke ykeisuke force-pushed the fix/planck-v7-with-encoder branch 3 times, most recently from 634f9c4 to 45167b6 Compare June 29, 2024 06:54
@ykeisuke
Copy link
Author

@drashna @sigprof @tzarc Excuse me, Could you continue review?

@drashna drashna requested a review from a team July 3, 2024 18:15
@tzarc tzarc mentioned this pull request Jul 4, 2024
Open
2 tasks
tzarc
tzarc requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, just cleanup and rewording.

keyboards/planck/rev7/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/planck/rev7/readme.md Outdated Show resolved Hide resolved
keyboards/planck/rev7/readme.md Outdated Show resolved Hide resolved
keyboards/planck/rev7/readme.md Outdated Show resolved Hide resolved
keyboards/planck/rev7/readme.md Outdated Show resolved Hide resolved
@ykeisuke ykeisuke force-pushed the fix/planck-v7-with-encoder branch from 98c3307 to 781d637 Compare July 7, 2024 15:03
@github-actions github-actions bot added documentation via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2024
@ykeisuke
Fix and Support ENCODER_MAP_ENABLE on Planck rev7
d30f6fa 
* Fix for encoders
* Support ENCODER_MAP_ENABLE feature
* Update readme.md
@ykeisuke
Replace no need functions and usage text, and even if using ENCODER_M…
0c2bcb6 
…AP_ENABLE, play melody.
@ykeisuke ykeisuke force-pushed the fix/planck-v7-with-encoder branch from 50961d3 to b25c466 Compare July 7, 2024 17:05
@github-actions github-actions bot removed documentation via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2024
@ykeisuke
Copy link
Author

ykeisuke commented Jul 7, 2024

@tzarc Thank you very much for your suggest changes. I did commit your suggestions and define play_encoder_melody for reduces the amount of code churn. Please re check.

@ykeisuke ykeisuke requested a review from tzarc July 7, 2024 17:11
@tzarc tzarc merged commit 54f907b into qmk:develop Jul 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ykeisuke @sigprof @drashna @tzarc