Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for encoders and support ENCODER_MAP_ENABLE on Planck rev7 #23967

Merged
merged 9 commits into from
Jul 7, 2024
Merged

Fix for encoders and support ENCODER_MAP_ENABLE on Planck rev7 #23967

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d30f6fa
Fix and Support ENCODER_MAP_ENABLE on Planck rev7
ykeisuke Jun 20, 2024
0c2bcb6
Replace no need functions and usage text, and even if using ENCODER_M…
ykeisuke Jun 21, 2024
1e4aee6
Use abstract codes
ykeisuke Jun 25, 2024
cc47d64
Update keyboards/planck/rev7/readme.md
ykeisuke Jul 7, 2024
3120a67
Update keyboards/planck/rev7/readme.md
ykeisuke Jul 7, 2024
2baa8bd
Update keyboards/planck/rev7/readme.md
ykeisuke Jul 7, 2024
fef9161
Update keyboards/planck/rev7/readme.md
ykeisuke Jul 7, 2024
6fdf7a9
define play_encoder_melody for reduces the amount of code churn
ykeisuke Jul 7, 2024
b25c466
Migrate keycodes of lights
ykeisuke Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update keyboards/planck/rev7/readme.md 
Co-authored-by: Nick Brassel <nick@tzarc.org>
  • Loading branch information
@ykeisuke @tzarc
ykeisuke and tzarc committed Jul 7, 2024
commit 3120a67afd0e79262d835e07e64dc5cf9255b5c7
2 changes: 1 addition & 1 deletion keyboards/planck/rev7/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ If an encoder has a switch built-in, it's connected to the key at that location
`-----------------------------------------------------------------------------------'
```

Planck rev7 support `ENCODER_ENABLE` and `ENCODER_MAP_ENABLE`. If both ENCODER_MAP_ENABLE and ENCODER_ENABLE are defined, ENCODER_MAP_ENABLE takes precedence. On the default keymap, each encoder will play its own rising/falling tone sequence when rotated, and will reset the pitch after one second of inactivity.
Planck rev7 supports `ENCODER_ENABLE` and `ENCODER_MAP_ENABLE`. If both `ENCODER_MAP_ENABLE` and `ENCODER_ENABLE` are defined, `ENCODER_MAP_ENABLE` takes precedence. On the default keymap, each encoder will play its own rising/falling tone sequence when rotated, and will reset the pitch after one second of inactivity.

### With ENCODER_ENABLE

Expand Down