Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yubino Hara keyboard #24042

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add Yubino Hara keyboard #24042

wants to merge 17 commits into from
+206 −0

Conversation

nagmeal
Copy link

@nagmeal nagmeal commented Jul 3, 2024 •
edited
Loading

Description

Add YUBINO-HARA keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 3, 2024
@nagmeal nagmeal changed the title add new keyboard. YUBINO-HARA Add Yubino Hara keyboard Jul 3, 2024
drashna
drashna requested changes Jul 3, 2024
View reviewed changes
keyboards/sepsepkbd/yubino_hara/keyboard.json Outdated Show resolved Hide resolved
keyboards/sepsepkbd/yubino_hara/readme.md Outdated Show resolved Hide resolved
waffle87
waffle87 reviewed Jul 3, 2024
View reviewed changes
keyboards/sepsepkbd/yubino_hara/keyboard.json Outdated Show resolved Hide resolved
keyboards/sepsepkbd/yubino_hara/keyboard.json Outdated Show resolved Hide resolved
keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/sepsepkbd/yubino_hara/readme.md Outdated Show resolved Hide resolved
waffle87
waffle87 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

keyboards/sepsepkbd/yubino_hara/readme.md Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team July 4, 2024 02:37
@nagmeal
Copy link
Author

nagmeal commented Jul 6, 2024 •
edited
Loading

@drashna
Hello,
There is one change request left that, but I can't find it.
Could you please tell me again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagmeal @drashna @waffle87