Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yubino Hara keyboard #24042

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
+206 −0
Open

Add Yubino Hara keyboard #24042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
532ba76
crkbdをコピーしてsepsepkbdを作成
nagmeal Apr 4, 2024
3f56cc6
qmk new-keyboardで再作成
nagmeal Apr 4, 2024
26aa0b5
名前入れ直し
nagmeal Apr 4, 2024
17f7f21
（多分）動く状態まで
nagmeal Apr 5, 2024
64d9dbe
keymap作成
nagmeal Apr 7, 2024
8dcdbfb
kemap/viaを一旦削除。普段使いと同じキー配置にdefaultキーマップを更新
nagmeal Apr 23, 2024
6d45ffb
yubino_hara
nagmeal May 21, 2024
1df17d9
動く事を確認できた状態
nagmeal May 22, 2024
7891abb
fiix
nagmeal May 23, 2024
4660f77
Importing the latest from fork source
nagmeal Jun 22, 2024
99ec7f9
LED compatible
nagmeal Jun 27, 2024
8eeb55a
reorganized directories
nagmeal Jun 27, 2024
c96449b
VIA support
nagmeal Jul 3, 2024
181920e
revet .vscode/settings.json
nagmeal Jul 3, 2024
ee20c8b
Move VIA_ENABLE to the via directory
nagmeal Jul 3, 2024
cd173c7
Corrected according to review
nagmeal Jul 3, 2024
a8a6f7b
correcting imgur URL
nagmeal Jul 4, 2024
8c93d5a
LAYOUT_split_6x3_3_1 -> LAYOUT_split_7x4
nagmeal Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Corrected according to review
  • Loading branch information
@nagmeal
nagmeal committed Jul 3, 2024
commit cd173c714e841622eb24ac33fb6fda98f4175c94
13 changes: 6 additions & 7 deletions keyboards/sepsepkbd/yubino_hara/keyboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,12 @@
"sync": {
"matrix_state": true
}
},
"usb_detect": {
"enabled": true
}
},
"matrix_pins": {
"cols": ["GP1", "GP2", "GP3", "GP4", "GP5", "GP6", "GP7"],
"rows": ["GP29", "GP28", "GP27", "GP26"]
},
"mouse_key": {
"enabled": true
},
"processor": "RP2040",
"url": "",
"usb": {
Expand All @@ -47,7 +41,12 @@
"led_count": 44,
"split": true,
"split_count": [22, 22],
"sleep": true
"sleep": true,
"default": {
"hue": 0,
"sat": 0,
"val": 50
}
},
"layouts": {
"LAYOUT_split_6x3_3_1": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a nitpick, but layout name should be (Rows)x(Columns).

Suggested change
"LAYOUT_split_6x3_3_1": {
"LAYOUT_split_3x6_3_1": {

Though, the keymaps would need to be changed too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I will fix it right away!

Is the maximum number correct?
It will be 7x4, so that's what I'll do.

Copy link
Member

@zvecr zvecr Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be 7x4, so that's what I'll do.

So the image from your readme, has 7 rows?

Given it doesnt match a community layout, I would suggest to rename it to just LAYOUT to avoid your confusion.

Expand Down
4 changes: 0 additions & 4 deletions keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
_______, _______, _______, _______, _______, _______
),
};

void keyboard_post_init_user(void) {
rgblight_sethsv(0, 0, 50);
}
4 changes: 0 additions & 4 deletions keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
_______, _______, _______, _______, _______, _______
),
};

void keyboard_post_init_user(void) {
rgblight_sethsv(0, 0, 100);
}
6 changes: 3 additions & 3 deletions keyboards/sepsepkbd/yubino_hara/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# yubino_hara

![yubino_hara](https://raw.githubusercontent.com/nagmeal/sep-sep-kbd/main/yubino-hara/yubinohara.jpg)
![yubino_hara](https://imgur.com/a/c91DXXL)
waffle87 marked this conversation as resolved.
Show resolved Hide resolved

- Split
- Reverse tilt (tilted from front to back)
Expand All @@ -16,11 +16,11 @@

Make example for this keyboard (after setting up your build environment):

qmk compile -kb sepsepkbd/yubino_hara -km default
make sepsepkbd/yubino_hara:default

Flashing example for this keyboard:

Connect to PC with USB cable and copy the generated fa2 file.
make sepsepkbd/yubino_hara:default:flash

See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).

Expand Down
Loading