Tradestation code tidy and readme refactor #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- correct JSON syntax on info.json - visual key alignment on info.json - white space changes on rules.mk and tradestation.h (readability/QMK conventions)
Modify readme.md to more closely match QMK template.
|
thank you so much for doing this. |
Update The Board podcast link for libsyn.
|
The template is more of a starting point. You can include extra information, as you have. Some of the readme files actually have fairly detailed build logs. |
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Jan 10, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (63 commits) Keymap: ave-63's iris layout (qmk#4812) Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810) Fix Mac mute keycode (qmk#4809) Add KBD75 keymap (qmk#4808) Fix pinout of split hand and LED, remove flip half option Tidy up Mod-Tap shortcuts (qmk#4806) Add missing parentheses to some important macros (qmk#4775) Keyboard: Downbubble refactor and Configurator fix (qmk#4798) Alternate keymap for Alpha keyboard, enjoy! (qmk#4797) Keymap: Added Model F-inspired layout for YMD[K]96 (qmk#4777) Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk (qmk#4774) Update to arm_atsam wait and timer routines Add Downbubble to Handwired repository (qmk#4794) Final HS60v2 changes. (qmk#4790) Keyboard: Fractal layout macro and readme cleanup (qmk#4789) Keymap: added my espectro keymap (qmk#4791) Keyboard: Numbrero: Configurator fix and code tidy (qmk#4787) Keyboard: Tradestation code tidy and readme refactor (qmk#4784) Keyboard: update readme with ps2avr flashing instructions (qmk#4776) add Pinky keyboard (qmk#4748) ...
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Tradestation: tidy code - correct JSON syntax on info.json - visual key alignment on info.json - white space changes on rules.mk and tradestation.h (readability/QMK conventions) * Tradestation: readme refactor Modify readme.md to more closely match QMK template. * Tradestation: readme update Update The Board podcast link for libsyn.
djthread
pushed a commit
to djthread/qmk_firmware
that referenced
this pull request
Mar 17, 2019
* Tradestation: tidy code - correct JSON syntax on info.json - visual key alignment on info.json - white space changes on rules.mk and tradestation.h (readability/QMK conventions) * Tradestation: readme refactor Modify readme.md to more closely match QMK template. * Tradestation: readme update Update The Board podcast link for libsyn.
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Tradestation: tidy code - correct JSON syntax on info.json - visual key alignment on info.json - white space changes on rules.mk and tradestation.h (readability/QMK conventions) * Tradestation: readme refactor Modify readme.md to more closely match QMK template. * Tradestation: readme update Update The Board podcast link for libsyn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Log
Tradestation: tidy code (c079a44)
Tradestation: readme refactor (ee5b0af)
Modify readme.md to more closely match QMK template.
Notes
@flehrad, the link in the readme for libsyn.com is "error 404" but I left it in in case you can provide me a good link. I searched but didn't find one.