Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Mod-Tap shortcuts #4806

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Tidy up Mod-Tap shortcuts #4806

merged 1 commit into from
Jan 9, 2019

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 8, 2019

Description

  • Reorganised the Mod-Tap shortcuts to all point to "base" definitions, eg. CMD_T → LCMD_T → LGUI_T.
  • Renamed ALL_T to HYPR_T and added it as an alias (so that it doesn't break anything). In future HYPR_T should be preferred over ALL_T, and eventually the alias should be removed.
  • Fixed a small typo in the alias list for LGUI_T.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

None.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Jan 9, 2019

Thanks!

@drashna drashna merged commit 3bd3008 into qmk:master Jan 9, 2019
@fauxpark fauxpark deleted the mt-aliases-tidy branch January 9, 2019 00:24
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jan 10, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
981cea7 
* 'master' of https://github.com/qmk/qmk_firmware: (63 commits)
  Keymap: ave-63's iris layout (qmk#4812)
  Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810)
  Fix Mac mute keycode (qmk#4809)
  Add KBD75 keymap (qmk#4808)
  Fix pinout of split hand and LED, remove flip half option
  Tidy up Mod-Tap shortcuts (qmk#4806)
  Add missing parentheses to some important macros (qmk#4775)
  Keyboard: Downbubble refactor and Configurator fix (qmk#4798)
  Alternate keymap for Alpha keyboard, enjoy! (qmk#4797)
  Keymap: Added Model F-inspired layout for YMD[K]96 (qmk#4777)
  Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk (qmk#4774)
  Update to arm_atsam wait and timer routines
  Add Downbubble to Handwired repository (qmk#4794)
  Final HS60v2 changes. (qmk#4790)
  Keyboard: Fractal layout macro and readme cleanup (qmk#4789)
  Keymap: added my espectro keymap (qmk#4791)
  Keyboard: Numbrero: Configurator fix and code tidy (qmk#4787)
  Keyboard: Tradestation code tidy and readme refactor (qmk#4784)
  Keyboard: update readme with ps2avr flashing instructions (qmk#4776)
  add Pinky keyboard (qmk#4748)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@fauxpark @rseymour
Tidy up Mod-Tap shortcuts (qmk#4806)
992ace7
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@fauxpark @djthread
Tidy up Mod-Tap shortcuts (qmk#4806)
246d54d
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@fauxpark
Tidy up Mod-Tap shortcuts (qmk#4806)
6364b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna