Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keycode handling for RGB #7677

Merged
merged 7 commits into from
Jun 22, 2020
Merged

Improve keycode handling for RGB #7677

merged 7 commits into from
Jun 22, 2020

Conversation

drashna
Copy link
Member

@drashna drashna commented Dec 19, 2019

Description

Specifically, this adds explicit calls for the rgb matrix code to the process_record_rgb function.

Right now, if you have both RGB Light and RGB Matrix enabled, it will only let you control the RGB Light functions, with no way to control the RGB Matrix features.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team December 19, 2019 09:31
noroadsleft
noroadsleft requested changes Jan 3, 2020
View reviewed changes
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 21, 2020 19:10
@stale
Copy link

stale bot commented Mar 6, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna and others added 6 commits April 12, 2020 20:21
@drashna
Improve keycode handling for RGB
e7941da 
Especially when both RGB Light and RGB Matrix are enabled at the same time
@drashna
Add documentation
d6f7cd7
@noroadsleft @drashna
Fix linked text
48a8f52 
Co-Authored-By: drashna <drashna@live.com>
@drashna
Change mode for swirl
0179ad1
@drashna
Fix merge conflict text
54be99c
@drashna
Fix unfinished line
38f1da9
noroadsleft
noroadsleft reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

@drashna drashna requested review from zvecr and a team April 28, 2020 00:40
@stale
Copy link

stale bot commented Jun 12, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jun 15, 2020
Erovia
Erovia approved these changes Jun 21, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erovia Erovia requested a review from a team June 21, 2020 10:01
@Erovia Erovia merged commit 98642ca into qmk:master Jun 22, 2020
@drashna drashna deleted the rgb/keycode_processing branch July 2, 2020 00:14
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@drashna @noroadsleft @jakobaa
Improve keycode handling for RGB (qmk#7677)
f5f09a8 
Co-authored-by: drashna <drashna@live.com>
Co-authored-by: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
drashna added a commit to zsa/qmk_firmware that referenced this pull request Aug 9, 2020
@drashna @noroadsleft
Improve keycode handling for RGB (qmk#7677)
0670312 
Co-authored-by: drashna <drashna@live.com>
Co-authored-by: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna @noroadsleft
Improve keycode handling for RGB (qmk#7677)
15e9673 
Co-authored-by: drashna <drashna@live.com>
Co-authored-by: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
awaiting review core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drashna @Erovia @fauxpark @noroadsleft @mechmerlin